Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5d39807

Browse files
committed
Add make dependency so that postgres.bki is rebuilt in major version change
Every time since the current rule for postgres.bki was put in place when we change the major version, people complain that their tests fail in strange ways. This is because the version number in postgres.bki is not updated, because it has no dependency for that. And you can't even force the rebuild manually if you don't happen to know which file has the problem. Fix that now before it will happen again. The only remaining problem with switching major versions, as far as the regression tests are concerned, is that contrib needs to be rebuilt. But that's easily invoked, and in any case the failure modes are more friendly if you forget that.
1 parent 1c882e0 commit 5d39807

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/backend/catalog/Makefile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,12 @@ postgres.shdescription: postgres.bki ;
5656

5757
schemapg.h: postgres.bki ;
5858

59-
postgres.bki: genbki.pl Catalog.pm $(POSTGRES_BKI_SRCS)
59+
# Technically, this should depend on Makefile.global, but then
60+
# postgres.bki would need to be rebuilt after every configure run,
61+
# even in distribution tarballs. So this is cheating a bit, but it
62+
# will achieve the goal of updating the version number when it
63+
# changes.
64+
postgres.bki: genbki.pl Catalog.pm $(POSTGRES_BKI_SRCS) $(top_srcdir)/configure
6065
$(PERL) -I $(catalogdir) $< $(pg_includes) --set-version=$(MAJORVERSION) $(POSTGRES_BKI_SRCS)
6166

6267
.PHONY: install-data

0 commit comments

Comments
 (0)