Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5e8068f

Browse files
committed
Change example in pgindent README on "/*-----" comments.
Most, but not all, of our "/*----" style comments have an end-guard line with dashes at the end of the comment. However, pgindent doesn't care about the end-guards, so they mostly just waste screen space. Going forward, let's not require end-guards. Remove a broken end-guard in a comment in walsender.c that led me to think about this. Remove the end guard from another comment in walsender.c for consistency, so that we use the same style in all comments in the file. However, we have thousands of existing "/*----" comments the repository, so it's not worth the code churn to change them all. Discussion: https://www.postgresql.org/message-id/fb083c91-d490-3b65-25f3-05e9118b6b0d%40iki.fi
1 parent a77d39d commit 5e8068f

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/backend/replication/walsender.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1197,7 +1197,6 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)
11971197
* - second field: LSN at which we became consistent
11981198
* - third field: exported snapshot's name
11991199
* - fourth field: output plugin
1200-
*----------
12011200
*/
12021201
tupdesc = CreateTemplateTupleDesc(4);
12031202
TupleDescInitBuiltinEntry(tupdesc, (AttrNumber) 1, "slot_name",
@@ -2692,7 +2691,7 @@ WalSndSegmentOpen(XLogReaderState *state, XLogSegNo nextSegNo,
26922691
* restored from the archive on this server, the file belonging to the old
26932692
* timeline, 000000040000000000000013, might not exist. Their contents are
26942693
* equal up to the switchpoint, because at a timeline switch, the used
2695-
* portion of the old segment is copied to the new file. -------
2694+
* portion of the old segment is copied to the new file.
26962695
*/
26972696
*tli_p = sendTimeLine;
26982697
if (sendTimeLineIsHistoric)

src/tools/pgindent/README

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ the comment block with some dashes:
104104

105105
/*----------
106106
* Text here will not be touched by pgindent.
107-
*----------
108107
*/
109108

110109
Odd spacing around typedef names might indicate an incomplete typedefs list.

0 commit comments

Comments
 (0)