Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5f340cb

Browse files
committed
Reinstate genhtml --prefix option for non-vpath builds
In c3d9a66, the genhtml --prefix option was removed to get slightly better behavior for vpath builds. genhtml would then automatically pick a suitable prefix. However, for non-vpath builds, this makes the coverage output dependent on the length of the path where the source code happens to be, leading to confusingly arbitrary results. So put the --prefix option back for non-vpath builds.
1 parent b81eba6 commit 5f340cb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Makefile.global.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -898,7 +898,7 @@ GENHTML_TITLE = PostgreSQL $(VERSION)
898898

899899
coverage-html-stamp: lcov_base.info lcov_test.info
900900
rm -rf coverage
901-
$(GENHTML) $(GENHTML_FLAGS) -o coverage --title='$(GENHTML_TITLE)' --num-spaces=4 $^
901+
$(GENHTML) $(GENHTML_FLAGS) -o coverage --title='$(GENHTML_TITLE)' --num-spaces=4 $(if $(filter no,$(vpath_build)),--prefix='$(abs_top_srcdir)') $^
902902
touch $@
903903

904904
LCOV += --gcov-tool $(GCOV)

0 commit comments

Comments
 (0)