Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 5f920de

Browse files
committed
Make PostgresNode.pm's poll_query_until() more chatty about failures.
Reporting only the stderr is unhelpful when the problem is that the server output we're getting doesn't match what was expected. So we should report the query output too; and just for good measure, let's print the query we used and the output we expected. Back-patch to 9.5 where poll_query_until was introduced. Discussion: https://postgr.es/m/17913.1539634756@sss.pgh.pa.us
1 parent 6d2c760 commit 5f920de

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

src/test/perl/PostgresNode.pm

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,9 +1348,18 @@ sub poll_query_until
13481348
$attempts++;
13491349
}
13501350

1351-
# The query result didn't change in 180 seconds. Give up. Print the stderr
1352-
# from the last attempt, hopefully that's useful for debugging.
1353-
diag $stderr;
1351+
# The query result didn't change in 180 seconds. Give up. Print the
1352+
# output from the last attempt, hopefully that's useful for debugging.
1353+
chomp($stderr);
1354+
$stderr =~ s/\r//g if $TestLib::windows_os;
1355+
diag qq(poll_query_until timed out executing this query:
1356+
$query
1357+
expecting this output:
1358+
$expected
1359+
last actual query output:
1360+
$stdout
1361+
with stderr:
1362+
$stderr);
13541363
return 0;
13551364
}
13561365

0 commit comments

Comments
 (0)