implicitely add referee_decision to the local relations hash. that fix posiible corruption of recovery due to pkey violation

Author: kelvich

multimaster.c

@@ -2311,7 +2311,7 @@ MtmCreateLocalTableMap(void)
 	return htab;
 }
 
-static void MtmMakeRelationLocal(Oid relid)
+void MtmMakeRelationLocal(Oid relid)
 {
 	if (OidIsValid(relid)) {
 		MtmLock(LW_EXCLUSIVE);

multimaster.h

@@ -432,6 +432,7 @@ extern void  MtmSetupReplicationHooks(struct PGLogicalHooks* hooks);
 extern bool  MtmRecoveryCaughtUp(int nodeId, lsn_t walEndPtr);
 extern void  MtmCheckRecoveryCaughtUp(int nodeId, lsn_t slotLSN);
 extern void  MtmMakeTableLocal(char const* schema, char const* name);
+extern void  MtmMakeRelationLocal(Oid relid);
 extern void  MtmHandleApplyError(void);
 extern void  MtmUpdateLsnMapping(int nodeId, lsn_t endLsn);
 extern lsn_t MtmGetFlushPosition(int nodeId);

pglogical_apply.c

@@ -859,7 +859,7 @@ process_remote_insert(StringInfo s, Relation rel)
 			/* TODO: Report tuple identity in log */
 			ereport(ERROR,
                     (errcode(ERRCODE_UNIQUE_VIOLATION),
-                     MTM_ERRMSG("Unique constraints violated by remotely INSERTed tuple"),
+					 MTM_ERRMSG("Unique constraints violated by remotely INSERTed tuple in %s", RelationGetRelationName(rel)),
                      errdetail("Cannot apply transaction because remotely INSERTed tuple conflicts with a local tuple on UNIQUE constraint and/or PRIMARY KEY")));
 		}
 		CHECK_FOR_INTERRUPTS();

state.c

@@ -577,13 +577,25 @@ MtmRefereeHasLocalTable()
 {
 	RangeVar   *rv;
 	Oid			rel_oid;
+	static bool _has_local_tables;
+
+	/* memoized */
+	if (_has_local_tables)
+		return true;
 
 	StartTransactionCommand();
 	rv = makeRangeVar(MULTIMASTER_SCHEMA_NAME, "referee_decision", -1);
 	rel_oid = RangeVarGetRelid(rv, NoLock, true);
 	CommitTransactionCommand();
 
-	return OidIsValid(rel_oid);
+	if (OidIsValid(rel_oid))
+	{
+		MtmMakeRelationLocal(rel_oid);
+		_has_local_tables = true;
+		return true;
+	}
+	else
+		return false;
 }
 
 static int