Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6336b6d

Browse files
committed
Correct pg_recvlogical server version test.
The predecessor test boiled down to "PQserverVersion(NULL) >= 100000", which is always false. No release includes that, so it could not have reintroduced CVE-2018-1058. Back-patch to 9.4, like the addition of the predecessor in commit 8d2814f. Discussion: https://postgr.es/m/20180422215551.GB2676194@rfd.leadboat.com
1 parent 5602265 commit 6336b6d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bin/pg_basebackup/streamutil.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ GetConnection(void)
223223
* 10, so the search path cannot be changed (by us or attackers) on
224224
* earlier versions.
225225
*/
226-
if (dbname != NULL && PQserverVersion(conn) >= 100000)
226+
if (dbname != NULL && PQserverVersion(tmpconn) >= 100000)
227227
{
228228
PGresult *res;
229229

0 commit comments

Comments
 (0)