Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 63585b1

Browse files
committed
doc: Fix description of replication command CREATE_REPLICATION_SLOT
The output plugin name is a mandatory option when creating a logical slot, but the grammar documented was not described as such. While on it, fix two comments in repl_gram.y to show that TEMPORARY is an optional grammar choice. Author: Ayaki Tachikake Discussion: https://postgr.es/m/OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.com Backpatch-through: 15
1 parent 2d27e13 commit 63585b1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

doc/src/sgml/protocol.sgml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1987,7 +1987,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
19871987
</varlistentry>
19881988

19891989
<varlistentry id="protocol-replication-create-replication-slot" xreflabel="CREATE_REPLICATION_SLOT">
1990-
<term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
1990+
<term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> <replaceable class="parameter">output_plugin</replaceable> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
19911991
<indexterm><primary>CREATE_REPLICATION_SLOT</primary></indexterm>
19921992
</term>
19931993
<listitem>

src/backend/replication/repl_gram.y

+2-2
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ base_backup:
172172
;
173173

174174
create_replication_slot:
175-
/* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options] */
175+
/* CREATE_REPLICATION_SLOT slot [TEMPORARY] PHYSICAL [options] */
176176
K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_PHYSICAL create_slot_options
177177
{
178178
CreateReplicationSlotCmd *cmd;
@@ -183,7 +183,7 @@ create_replication_slot:
183183
cmd->options = $5;
184184
$$ = (Node *) cmd;
185185
}
186-
/* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options] */
186+
/* CREATE_REPLICATION_SLOT slot [TEMPORARY] LOGICAL plugin [options] */
187187
| K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_LOGICAL IDENT create_slot_options
188188
{
189189
CreateReplicationSlotCmd *cmd;

0 commit comments

Comments
 (0)