Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6544546

Browse files
amcheck: Reduce debug message verbosity.
Empty sibling pages can occasionally be much more common than any other event that we report on at elevel DEBUG1. Increase the elevel for relevant cases to DEBUG2 to avoid overwhelming the user with relatively insignificant details.
1 parent 4b12ab1 commit 6544546

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

contrib/amcheck/verify_nbtree.c

+11-7
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ bt_check_level_from_leftmost(BtreeCheckState *state, BtreeLevel level)
721721
else
722722
ereport(DEBUG1,
723723
(errcode(ERRCODE_NO_DATA),
724-
errmsg_internal("block %u of index \"%s\" ignored",
724+
errmsg_internal("block %u of index \"%s\" concurrently deleted",
725725
current, RelationGetRelationName(state->rel))));
726726
goto nextpage;
727727
}
@@ -1592,14 +1592,18 @@ bt_right_page_check_scankey(BtreeCheckState *state)
15921592
if (!P_IGNORE(opaque) || P_RIGHTMOST(opaque))
15931593
break;
15941594

1595-
/* We landed on a deleted page, so step right to find a live page */
1596-
targetnext = opaque->btpo_next;
1597-
ereport(DEBUG1,
1595+
/*
1596+
* We landed on a deleted or half-dead sibling page. Step right until
1597+
* we locate a live sibling page.
1598+
*/
1599+
ereport(DEBUG2,
15981600
(errcode(ERRCODE_NO_DATA),
1599-
errmsg_internal("level %u leftmost page of index \"%s\" was found deleted or half dead",
1600-
opaque->btpo_level, RelationGetRelationName(state->rel)),
1601+
errmsg_internal("level %u sibling page in block %u of index \"%s\" was found deleted or half dead",
1602+
opaque->btpo_level, targetnext, RelationGetRelationName(state->rel)),
16011603
errdetail_internal("Deleted page found when building scankey from right sibling.")));
16021604

1605+
targetnext = opaque->btpo_next;
1606+
16031607
/* Be slightly more pro-active in freeing this memory, just in case */
16041608
pfree(rightpage);
16051609
}
@@ -1722,7 +1726,7 @@ bt_right_page_check_scankey(BtreeCheckState *state)
17221726
* possible that it's an internal page with only a negative infinity
17231727
* item.
17241728
*/
1725-
ereport(DEBUG1,
1729+
ereport(DEBUG2,
17261730
(errcode(ERRCODE_NO_DATA),
17271731
errmsg_internal("%s block %u of index \"%s\" has no first data item",
17281732
P_ISLEAF(opaque) ? "leaf" : "internal", targetnext,

0 commit comments

Comments
 (0)