Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 65b9671

Browse files
committed
pg_upgrade: improve C comment about what old/new oids match
1 parent dd917bb commit 65b9671

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

contrib/pg_upgrade/pg_upgrade.c

+6-7
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
* oids are the same between old and new clusters. This is important
1616
* because toast oids are stored as toast pointers in user tables.
1717
*
18-
* FYI, while pg_class.oid and pg_class.relfilenode are initially the same
19-
* in a cluster, but they can diverge due to CLUSTER, REINDEX, or VACUUM
20-
* FULL. The new cluster will have matching pg_class.oid and
21-
* pg_class.relfilenode values and be based on the old oid value. This can
22-
* cause the old and new pg_class.relfilenode values to differ. In summary,
23-
* old and new pg_class.oid and new pg_class.relfilenode will have the
24-
* same value, and old pg_class.relfilenode might differ.
18+
* While pg_class.oid and pg_class.relfilenode are initially the same
19+
* in a cluster, they can diverge due to CLUSTER, REINDEX, or VACUUM
20+
* FULL. In the new cluster, pg_class.oid and pg_class.relfilenode will
21+
* be the same and will match the old pg_class.oid value. Because of
22+
* this, old/new pg_class.relfilenode values will not match if CLUSTER,
23+
* REINDEX, or VACUUM FULL have been performed in the old cluster.
2524
*
2625
* We control all assignments of pg_type.oid because these oids are stored
2726
* in user composite type values.

0 commit comments

Comments
 (0)