Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6693eb7

Browse files
committed
timeline is not needed in BaseBackup()
This code was accidentally part of the patch, it's only needed for the code that's for 9.2. Not needing the timeline also removes the need to call IDENTIFY_SYSTEM. Noted by Peter E.
1 parent 4f6c75b commit 6693eb7

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

src/bin/pg_basebackup/pg_basebackup.c

-20
Original file line numberDiff line numberDiff line change
@@ -756,7 +756,6 @@ static void
756756
BaseBackup(void)
757757
{
758758
PGresult *res;
759-
uint32 timeline;
760759
char current_path[MAXPGPATH];
761760
char escaped_label[MAXPGPATH];
762761
int i;
@@ -768,25 +767,6 @@ BaseBackup(void)
768767
*/
769768
conn = GetConnection();
770769

771-
/*
772-
* Run IDENFITY_SYSTEM so we can get the timeline
773-
*/
774-
res = PQexec(conn, "IDENTIFY_SYSTEM");
775-
if (PQresultStatus(res) != PGRES_TUPLES_OK)
776-
{
777-
fprintf(stderr, _("%s: could not identify system: %s\n"),
778-
progname, PQerrorMessage(conn));
779-
disconnect_and_exit(1);
780-
}
781-
if (PQntuples(res) != 1)
782-
{
783-
fprintf(stderr, _("%s: could not identify system, got %i rows\n"),
784-
progname, PQntuples(res));
785-
disconnect_and_exit(1);
786-
}
787-
timeline = atoi(PQgetvalue(res, 0, 1));
788-
PQclear(res);
789-
790770
/*
791771
* Start the actual backup
792772
*/

0 commit comments

Comments
 (0)