Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 690c880

Browse files
committed
Improve some comments in pg_upgrade.c
When restoring database schemas on a new cluster, database "template1" is processed first, followed by all other databases in parallel, including "postgres". Both "postgres" and "template1" have some extra handling to propagate each one's properties, but comments were confusing regarding which one is processed where. Author: Julien Rouhaud Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/CAOBaU_a2iviTG7FE10yO_gcW+zQCHNFhRA_NDiktf3UR65BHdw@mail.gmail.com
1 parent 28f4bba commit 690c880

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/bin/pg_upgrade/pg_upgrade.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -341,10 +341,9 @@ create_new_objects(void)
341341
snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid);
342342

343343
/*
344-
* template1 and postgres databases will already exist in the target
345-
* installation, so tell pg_restore to drop and recreate them;
346-
* otherwise we would fail to propagate their database-level
347-
* properties.
344+
* template1 database will already exist in the target installation,
345+
* so tell pg_restore to drop and recreate it; otherwise we would fail
346+
* to propagate its database-level properties.
348347
*/
349348
create_opts = "--clean --create";
350349

@@ -378,10 +377,9 @@ create_new_objects(void)
378377
snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid);
379378

380379
/*
381-
* template1 and postgres databases will already exist in the target
382-
* installation, so tell pg_restore to drop and recreate them;
383-
* otherwise we would fail to propagate their database-level
384-
* properties.
380+
* postgres database will already exist in the target installation, so
381+
* tell pg_restore to drop and recreate it; otherwise we would fail to
382+
* propagate its database-level properties.
385383
*/
386384
if (strcmp(old_db->db_name, "postgres") == 0)
387385
create_opts = "--clean --create";

0 commit comments

Comments
 (0)