Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 697dd19

Browse files
committed
Remove bogus assertion in transformExpressionList().
I think when I added this assertion (in commit 8f889b1), I was only thinking of the use of transformExpressionList at top level of INSERT and VALUES. But it's also called by transformRowExpr(), which can certainly occur in an UPDATE targetlist, so it's inappropriate to suppose that p_multiassign_exprs must be empty. Besides, since the input is not expected to contain ResTargets, there's no reason it should contain MultiAssignRefs either. Hence this code need not be concerned about the state of p_multiassign_exprs, and we should just drop the assertion. Per bug #17236 from ocean_li_996. It's been wrong for years, so back-patch to all supported branches. Discussion: https://postgr.es/m/17236-3210de9bcba1d7ca@postgresql.org
1 parent 998d060 commit 697dd19

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/backend/parser/parse_target.c

+3-4
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,9 @@ transformTargetList(ParseState *pstate, List *targetlist,
211211
* This is the identical transformation to transformTargetList, except that
212212
* the input list elements are bare expressions without ResTarget decoration,
213213
* and the output elements are likewise just expressions without TargetEntry
214-
* decoration. We use this for ROW() and VALUES() constructs.
214+
* decoration. Also, we don't expect any multiassign constructs within the
215+
* list, so there's nothing to do for that. We use this for ROW() and
216+
* VALUES() constructs.
215217
*
216218
* exprKind is not enough to tell us whether to allow SetToDefault, so
217219
* an additional flag is needed for that.
@@ -273,9 +275,6 @@ transformExpressionList(ParseState *pstate, List *exprlist,
273275
result = lappend(result, e);
274276
}
275277

276-
/* Shouldn't have any multiassign items here */
277-
Assert(pstate->p_multiassign_exprs == NIL);
278-
279278
return result;
280279
}
281280

0 commit comments

Comments
 (0)