Fix pgbench's parsing of double values to notice trailing garbage.

tglsfdc · tglsfdc · commit 6b8b4e4d8320 · 2016-05-06T11:08:48.000-04:00
Noted by Fabien Coelho, though this isn't exactly his proposed patch.
(The technique used here is borrowed from the zic sources.)
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -928,8 +928,9 @@ makeVariableNumeric(Variable *var)
 	else /* type should be double */
 	{
 		double dv;
+		char xs;
 
-		if (sscanf(var->value, "%lf", &dv) != 1)
+		if (sscanf(var->value, "%lf%c", &dv, &xs) != 1)
 		{
 			fprintf(stderr,
 					"malformed variable \"%s\" value: \"%s\"\n",

Original file line number	Diff line number	Diff line change
`@@ -928,8 +928,9 @@ makeVariableNumeric(Variable *var)`
`928`	`928`	`else /* type should be double */`
`929`	`929`	`{`
`930`	`930`	`double dv;`
	`931`	`+ char xs;`
`931`	`932`
`932`		`- if (sscanf(var->value, "%lf", &dv) != 1)`
	`933`	`+ if (sscanf(var->value, "%lf%c", &dv, &xs) != 1)`
`933`	`934`	`{`
`934`	`935`	`fprintf(stderr,`
`935`	`936`	`"malformed variable \"%s\" value: \"%s\"\n",`