Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6ba6306

Browse files
committed
Fix failure with perlcritic in psql's create_help.pl
No buildfarm members have reported that yet, but a recently-refreshed Debian host did. Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/Y8ey5z4Nav62g4/K@paquier.xyz Backpatch-through: 11
1 parent a3b65fb commit 6ba6306

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/bin/psql/create_help.pl

+3-3
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
$define =~ tr/a-z/A-Z/;
4545
$define =~ s/\W/_/g;
4646

47-
opendir(DIR, $docdir)
47+
opendir(my $dh, $docdir)
4848
or die "$0: could not open documentation source dir '$docdir': $!\n";
4949
open(my $hfile_handle, '>', "$outdir/$hfile")
5050
or die "$0: could not open output file '$hfile': $!\n";
@@ -103,7 +103,7 @@
103103

104104
my %entries;
105105

106-
foreach my $file (sort readdir DIR)
106+
foreach my $file (sort readdir $dh)
107107
{
108108
my ($cmdid, @cmdnames, $cmddesc, $cmdsynopsis);
109109
$file =~ /\.sgml$/ or next;
@@ -230,4 +230,4 @@
230230
close $cfile_handle;
231231
close $hfile_handle;
232232
close $depfile_handle if ($depfile);
233-
closedir DIR;
233+
closedir $dh;

0 commit comments

Comments
 (0)