Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6c2e734

Browse files
committed
Refactor ALTER EXTENSION UPDATE to have cleaner multi-step semantics.
This change causes a multi-step update sequence to behave exactly as if the updates had been commanded one at a time, including updating the "requires" dependencies afresh at each step. The initial implementation took the shortcut of examining only the final target version's "requires" and changing the catalog entry but once. But on reflection that's a bad idea, since it could lead to executing old update scripts under conditions different than they were designed/tested for. Better to expend a few extra cycles and avoid any surprises. In the same spirit, if a CREATE EXTENSION FROM operation involves applying a series of update files, it will act as though the CREATE had first been done using the initial script's target version and then the additional scripts were invoked with ALTER EXTENSION UPDATE. I also removed the restriction about not changing encoding in secondary control files. The new rule is that a script is assumed to be in whatever encoding the control file(s) specify for its target version. Since this reimplementation causes us to read each intermediate version's control file, there's no longer any uncertainty about which encoding setting would get applied.
1 parent 0de0cc1 commit 6c2e734

File tree

2 files changed

+252
-144
lines changed

2 files changed

+252
-144
lines changed

doc/src/sgml/extend.sgml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -482,10 +482,8 @@
482482
Secondary control files follow the same format as the primary control
483483
file. Any parameters set in a secondary control file override the
484484
primary control file when installing or updating to that version of
485-
the extension. However, the parameters <varname>directory</>,
486-
<varname>default_version</>, and <varname>encoding</> cannot be set in
487-
a secondary control file; in particular, the same encoding must be used
488-
in all script files associated with the extension.
485+
the extension. However, the parameters <varname>directory</> and
486+
<varname>default_version</> cannot be set in a secondary control file.
489487
</para>
490488

491489
<para>
@@ -689,6 +687,12 @@ SELECT pg_catalog.pg_extension_config_dump('my_config', 'WHERE NOT standard_entr
689687
to the extension.
690688
</para>
691689

690+
<para>
691+
If an extension has secondary control files, the control parameters
692+
that are used for an update script are those associated with the script's
693+
target (new) version.
694+
</para>
695+
692696
<para>
693697
The update mechanism can be used to solve an important special case:
694698
converting a <quote>loose</> collection of objects into an extension.
@@ -808,7 +812,7 @@ include $(PGXS)
808812

809813
This makefile relies on <acronym>PGXS</acronym>, which is described
810814
in <xref linkend="extend-pgxs">. The command <literal>make install</>
811-
will then install the control and script files into the correct
815+
will install the control and script files into the correct
812816
directory as reported by <application>pg_config</>.
813817
</para>
814818

0 commit comments

Comments
 (0)