Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6c4996f

Browse files
committed
GROUP BY got confused if there were multiple equal() GROUP BY items.
This bug has been latent since 7.0 or maybe even further back, but it was only exposed when parse_clause.c stopped suppressing duplicate items (see its rev 1.96 of 18-Aug-02).
1 parent 706a32c commit 6c4996f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/backend/optimizer/plan/planner.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.151 2003/03/10 03:53:50 tgl Exp $
11+
* $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.152 2003/03/13 16:58:35 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -1489,13 +1489,14 @@ make_groupsortplan(Query *parse,
14891489
Plan *subplan)
14901490
{
14911491
List *sort_tlist = new_unsorted_tlist(subplan->targetlist);
1492+
int grpno = 0;
14921493
int keyno = 0;
14931494
List *gl;
14941495

14951496
foreach(gl, groupClause)
14961497
{
14971498
GroupClause *grpcl = (GroupClause *) lfirst(gl);
1498-
TargetEntry *te = nth(grpColIdx[keyno] - 1, sort_tlist);
1499+
TargetEntry *te = nth(grpColIdx[grpno] - 1, sort_tlist);
14991500
Resdom *resdom = te->resdom;
15001501

15011502
/*
@@ -1509,6 +1510,7 @@ make_groupsortplan(Query *parse,
15091510
resdom->reskey = ++keyno;
15101511
resdom->reskeyop = grpcl->sortop;
15111512
}
1513+
grpno++;
15121514
}
15131515

15141516
Assert(keyno > 0);

0 commit comments

Comments
 (0)