Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 6ff2e8c

Browse files
Simplify version check for SKIP clause
Checking for the required versions of IO::Pty as well as IPC::Run can be achieved with a single eval call, and by using the VERSION function the comparison is guaranteed to follow the same rules as calling 'use' on the module with a version. Reported-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net
1 parent 980e887 commit 6ff2e8c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/authentication/t/001_password.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ sub test_conn
107107
SKIP:
108108
{
109109
skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
110-
(eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });
110+
eval { require IO::Pty; IPC::Run->VERSION('0.98'); };
111111

112112
# Alter the password on the created role using \password in psql to ensure
113113
# that clientside password changes use the scram_iterations value when

0 commit comments

Comments
 (0)