Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 704e1db

Browse files
committed
Remove some useless logs from the TAP tests of pgbench
002_pgbench_no_server was printing some array pointers instead of the actual contents of those arrays for the expected outputs of stdout and stderr for a tested command. This does not add any new information that can help with debugging as the test names allow to track failure locations, if any. This commit simply removes those logs as the rest of the printed information is redundant with command_checks_all(). Per discussion with Andrew Dunstan and Álvaro Herrera. Discussion: https://postgr.es/m/YNXNFaG7IgkzZanD@paquier.xyz Backpatch-through: 11
1 parent 5a0f1c8 commit 704e1db

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/bin/pgbench/t/002_pgbench_no_server.pl

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ sub pgbench
2626
local $Test::Builder::Level = $Test::Builder::Level + 1;
2727

2828
my ($opts, $stat, $out, $err, $name) = @_;
29-
print STDERR "opts=$opts, stat=$stat, out=$out, err=$err, name=$name";
3029
command_checks_all([ 'pgbench', split(/\s+/, $opts) ],
3130
$stat, $out, $err, $name);
3231
return;

0 commit comments

Comments
 (0)