Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 748507c

Browse files
committed
Sync up some inconsistent comments in config/c-compiler.m4.
Make header/trailer comments agree with the actual names of some macros. These seem like legit names in earlier iterations of respective patches (commit b779168 "Detect PG_PRINTF_ATTRIBUTE automatically." and commit 6869b4f "Add C++ support to configure.") but the macro had been renamed out of sync with the header / trailer comment in the final committed patch. Even more nitpickily, make the dashed underlines agree with the lengths of the macro names everyplace. There doesn't seem to have been any meeting of the minds previously on whether those should match or not, but at least some people have been trying to make 'em match. Jesse Zhang, Tom Lane Discussion: https://postgr.es/m/CAGf+fX7DDyq6WfCy6X_KtD28MkbNBE6NkRi26fSf25dfUwX0zw@mail.gmail.com
1 parent 791090b commit 748507c

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

config/c-compiler.m4

+18-18
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# config/c-compiler.m4
33

44

5-
# PGAC_C_PRINTF_ARCHETYPE
6-
# -----------------------
5+
# PGAC_PRINTF_ARCHETYPE
6+
# ---------------------
77
# Select the format archetype to be used by gcc to check printf-type functions.
88
# We prefer "gnu_printf", as that most closely matches the features supported
99
# by src/port/snprintf.c (particularly the %m conversion spec). However,
@@ -93,7 +93,7 @@ undefine([Ac_cachevar])dnl
9393

9494

9595
# PGAC_TYPE_128BIT_INT
96-
# ---------------------
96+
# --------------------
9797
# Check if __int128 is a working 128 bit integer type, and if so
9898
# define PG_INT128_TYPE to that typename, and define ALIGNOF_PG_INT128_TYPE
9999
# as its alignment requirement.
@@ -282,7 +282,7 @@ fi])# PGAC_C_BUILTIN_CONSTANT_P
282282

283283

284284
# PGAC_C_BUILTIN_OP_OVERFLOW
285-
# -------------------------
285+
# --------------------------
286286
# Check if the C compiler understands __builtin_$op_overflow(),
287287
# and define HAVE__BUILTIN_OP_OVERFLOW if so.
288288
#
@@ -331,7 +331,7 @@ fi])# PGAC_C_BUILTIN_UNREACHABLE
331331

332332

333333
# PGAC_C_COMPUTED_GOTO
334-
# -----------------------
334+
# --------------------
335335
# Check if the C compiler knows computed gotos (gcc extension, also
336336
# available in at least clang). If so, define HAVE_COMPUTED_GOTO.
337337
#
@@ -382,7 +382,7 @@ fi])# PGAC_CHECK_BUILTIN_FUNC
382382

383383

384384
# PGAC_PROG_VARCC_VARFLAGS_OPT
385-
# -----------------------
385+
# ----------------------------
386386
# Given a compiler, variable name and a string, check if the compiler
387387
# supports the string as a command-line option. If it does, add the
388388
# string to the given variable.
@@ -420,7 +420,7 @@ PGAC_PROG_VARCC_VARFLAGS_OPT(CC, CFLAGS, $1)
420420

421421

422422
# PGAC_PROG_CC_VAR_OPT
423-
# -----------------------
423+
# --------------------
424424
# Given a variable name and a string, check if the compiler supports
425425
# the string as a command-line option. If it does, add the string to
426426
# the given variable.
@@ -431,7 +431,7 @@ AC_DEFUN([PGAC_PROG_CC_VAR_OPT],
431431

432432

433433
# PGAC_PROG_VARCXX_VARFLAGS_OPT
434-
# -----------------------
434+
# -----------------------------
435435
# Given a compiler, variable name and a string, check if the compiler
436436
# supports the string as a command-line option. If it does, add the
437437
# string to the given variable.
@@ -461,12 +461,12 @@ undefine([Ac_cachevar])dnl
461461

462462

463463
# PGAC_PROG_CXX_CFLAGS_OPT
464-
# -----------------------
464+
# ------------------------
465465
# Given a string, check if the compiler supports the string as a
466466
# command-line option. If it does, add the string to CXXFLAGS.
467467
AC_DEFUN([PGAC_PROG_CXX_CFLAGS_OPT],
468468
[PGAC_PROG_VARCXX_VARFLAGS_OPT(CXX, CXXFLAGS, $1)
469-
])# PGAC_PROG_CXX_VAR_OPT
469+
])# PGAC_PROG_CXX_CFLAGS_OPT
470470

471471

472472

@@ -494,7 +494,7 @@ undefine([Ac_cachevar])dnl
494494
])# PGAC_PROG_CC_LDFLAGS_OPT
495495

496496
# PGAC_HAVE_GCC__SYNC_CHAR_TAS
497-
# -------------------------
497+
# ----------------------------
498498
# Check if the C compiler understands __sync_lock_test_and_set(char),
499499
# and define HAVE_GCC__SYNC_CHAR_TAS
500500
#
@@ -514,7 +514,7 @@ if test x"$pgac_cv_gcc_sync_char_tas" = x"yes"; then
514514
fi])# PGAC_HAVE_GCC__SYNC_CHAR_TAS
515515

516516
# PGAC_HAVE_GCC__SYNC_INT32_TAS
517-
# -------------------------
517+
# -----------------------------
518518
# Check if the C compiler understands __sync_lock_test_and_set(),
519519
# and define HAVE_GCC__SYNC_INT32_TAS
520520
AC_DEFUN([PGAC_HAVE_GCC__SYNC_INT32_TAS],
@@ -530,7 +530,7 @@ if test x"$pgac_cv_gcc_sync_int32_tas" = x"yes"; then
530530
fi])# PGAC_HAVE_GCC__SYNC_INT32_TAS
531531

532532
# PGAC_HAVE_GCC__SYNC_INT32_CAS
533-
# -------------------------
533+
# -----------------------------
534534
# Check if the C compiler understands __sync_compare_and_swap() for 32bit
535535
# types, and define HAVE_GCC__SYNC_INT32_CAS if so.
536536
AC_DEFUN([PGAC_HAVE_GCC__SYNC_INT32_CAS],
@@ -545,7 +545,7 @@ if test x"$pgac_cv_gcc_sync_int32_cas" = x"yes"; then
545545
fi])# PGAC_HAVE_GCC__SYNC_INT32_CAS
546546

547547
# PGAC_HAVE_GCC__SYNC_INT64_CAS
548-
# -------------------------
548+
# -----------------------------
549549
# Check if the C compiler understands __sync_compare_and_swap() for 64bit
550550
# types, and define HAVE_GCC__SYNC_INT64_CAS if so.
551551
AC_DEFUN([PGAC_HAVE_GCC__SYNC_INT64_CAS],
@@ -560,7 +560,7 @@ if test x"$pgac_cv_gcc_sync_int64_cas" = x"yes"; then
560560
fi])# PGAC_HAVE_GCC__SYNC_INT64_CAS
561561

562562
# PGAC_HAVE_GCC__ATOMIC_INT32_CAS
563-
# -------------------------
563+
# -------------------------------
564564
# Check if the C compiler understands __atomic_compare_exchange_n() for 32bit
565565
# types, and define HAVE_GCC__ATOMIC_INT32_CAS if so.
566566
AC_DEFUN([PGAC_HAVE_GCC__ATOMIC_INT32_CAS],
@@ -576,7 +576,7 @@ if test x"$pgac_cv_gcc_atomic_int32_cas" = x"yes"; then
576576
fi])# PGAC_HAVE_GCC__ATOMIC_INT32_CAS
577577

578578
# PGAC_HAVE_GCC__ATOMIC_INT64_CAS
579-
# -------------------------
579+
# -------------------------------
580580
# Check if the C compiler understands __atomic_compare_exchange_n() for 64bit
581581
# types, and define HAVE_GCC__ATOMIC_INT64_CAS if so.
582582
AC_DEFUN([PGAC_HAVE_GCC__ATOMIC_INT64_CAS],
@@ -592,7 +592,7 @@ if test x"$pgac_cv_gcc_atomic_int64_cas" = x"yes"; then
592592
fi])# PGAC_HAVE_GCC__ATOMIC_INT64_CAS
593593

594594
# PGAC_SSE42_CRC32_INTRINSICS
595-
# -----------------------
595+
# ---------------------------
596596
# Check if the compiler supports the x86 CRC instructions added in SSE 4.2,
597597
# using the _mm_crc32_u8 and _mm_crc32_u32 intrinsic functions. (We don't
598598
# test the 8-byte variant, _mm_crc32_u64, but it is assumed to be present if
@@ -623,7 +623,7 @@ undefine([Ac_cachevar])dnl
623623

624624

625625
# PGAC_ARMV8_CRC32C_INTRINSICS
626-
# -----------------------
626+
# ----------------------------
627627
# Check if the compiler supports the CRC32C instructions using the __crc32cb,
628628
# __crc32ch, __crc32cw, and __crc32cd intrinsic functions. These instructions
629629
# were first introduced in ARMv8 in the optional CRC Extension, and became

0 commit comments

Comments
 (0)