Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 7558cc9

Browse files
committed
Error out on send failure in walsender loop.
I changed the loop in 9.3 to use "goto send_failure" instead of "break" on errors, but I missed this one case. It was a relatively harmless bug: if the flush fails once it will most likely fail again as soon as we try to flush the output again. But it's a bug nevertheless. Report and fix by Andres Freund.
1 parent b89e151 commit 7558cc9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/backend/replication/walsender.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1291,7 +1291,7 @@ WalSndLoop(void)
12911291
ping_sent = true;
12921292
/* Try to flush pending output to the client */
12931293
if (pq_flush_if_writable() != 0)
1294-
break;
1294+
goto send_failure;
12951295
}
12961296
}
12971297

0 commit comments

Comments
 (0)