Minor tweaks on libpqrcv_connect(): ensure conninfo_repl[] is

simonat2ndQuadrant · simonat2ndQuadrant · commit 75867c528d45 · 2010-03-19T17:51:42.000Z
correctly sized and expand comment to explain otherwise
undocumented use of replication connection parameter.
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -10,7 +10,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.5 2010/02/26 02:00:58 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.6 2010/03/19 17:51:42 sriggs Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -76,15 +76,15 @@ _PG_init(void)
 static bool
 libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)
 {
-	char		conninfo_repl[MAXCONNINFO + 14];
+	char		conninfo_repl[MAXCONNINFO + 18];
 	char	   *primary_sysid;
 	char		standby_sysid[32];
 	TimeLineID	primary_tli;
 	TimeLineID	standby_tli;
 	PGresult   *res;
 	char		cmd[64];
 
-	/* Connect */
+	/* Connect using deliberately undocumented parameter: replication */
 	snprintf(conninfo_repl, sizeof(conninfo_repl), "%s replication=true", conninfo);
 
 	streamConn = PQconnectdb(conninfo_repl);

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.5 2010/02/26 02:00:58 momjian Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.6 2010/03/19 17:51:42 sriggs Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -76,15 +76,15 @@ _PG_init(void)`
`76`	`76`	`static bool`
`77`	`77`	`libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)`
`78`	`78`	`{`
`79`		`- char conninfo_repl[MAXCONNINFO + 14];`
	`79`	`+ char conninfo_repl[MAXCONNINFO + 18];`
`80`	`80`	`char *primary_sysid;`
`81`	`81`	`char standby_sysid[32];`
`82`	`82`	`TimeLineID primary_tli;`
`83`	`83`	`TimeLineID standby_tli;`
`84`	`84`	`PGresult *res;`
`85`	`85`	`char cmd[64];`
`86`	`86`
`87`		`- /* Connect */`
	`87`	`+ /* Connect using deliberately undocumented parameter: replication */`
`88`	`88`	`snprintf(conninfo_repl, sizeof(conninfo_repl), "%s replication=true", conninfo);`
`89`	`89`
`90`	`90`	`streamConn = PQconnectdb(conninfo_repl);`