Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 75b3b13

Browse files
committed
Avoid rare race condition in privileges.sql regression test.
We created a temp table, then switched to a new session, leaving the old session to clean up its temp objects in background. If that took long enough, the eventual attempt to drop the user that owns the temp table could fail, as exhibited today by sidewinder. Fix by dropping the temp table explicitly when we're done with it. It's been like this for quite some time, so back-patch to all supported branches. Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2018-10-16%2014%3A45%3A00
1 parent a485bac commit 75b3b13

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/test/regress/expected/privileges.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,7 @@ select has_column_privilege('mytable',2::int2,'select');
11361136

11371137
(1 row)
11381138

1139+
drop table mytable;
11391140
-- Grant options
11401141
SET SESSION AUTHORIZATION regress_user1;
11411142
CREATE TABLE atest4 (a int);

src/test/regress/sql/privileges.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -706,6 +706,7 @@ select has_column_privilege('mytable','........pg.dropped.2........','select');
706706
select has_column_privilege('mytable',2::int2,'select');
707707
revoke select on table mytable from regress_user3;
708708
select has_column_privilege('mytable',2::int2,'select');
709+
drop table mytable;
709710

710711
-- Grant options
711712

0 commit comments

Comments
 (0)