Add mention loops over unlink/rename might not be needed.

bmomjian · bmomjian · commit 777687c6de4f · 2004-09-10T09:58:21.000Z
diff --git a/src/port/dirmod.c b/src/port/dirmod.c
@@ -10,7 +10,7 @@
  *	Win32 (NT, Win2k, XP).	replace() doesn't work on Win95/98/Me.
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/port/dirmod.c,v 1.25 2004/09/10 09:53:08 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/port/dirmod.c,v 1.26 2004/09/10 09:58:21 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -68,6 +68,7 @@ pgrename(const char *from, const char *to)
 {
 	int			loops = 0;
 
+	/* Is this looped even necessary?  */
 #if defined(WIN32) && !defined(__CYGWIN__)
 	while (!MoveFileEx(from, to, MOVEFILE_REPLACE_EXISTING))
 #endif
@@ -113,6 +114,7 @@ pgunlink(const char *path)
 {
 	int			loops = 0;
 
+	/* Is this looped even necessary?  */
 	while (unlink(path))
 	{
 		if (errno != EACCES)

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Win32 (NT, Win2k, XP). replace() doesn't work on Win95/98/Me.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/port/dirmod.c,v 1.25 2004/09/10 09:53:08 momjian Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/port/dirmod.c,v 1.26 2004/09/10 09:58:21 momjian Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -68,6 +68,7 @@ pgrename(const char from, const char to)`
`68`	`68`	`{`
`69`	`69`	`int loops = 0;`
`70`	`70`
	`71`	`+ /* Is this looped even necessary? */`
`71`	`72`	`#if defined(WIN32) && !defined(__CYGWIN__)`
`72`	`73`	`while (!MoveFileEx(from, to, MOVEFILE_REPLACE_EXISTING))`
`73`	`74`	`#endif`
`@@ -113,6 +114,7 @@ pgunlink(const char *path)`
`113`	`114`	`{`
`114`	`115`	`int loops = 0;`
`115`	`116`
	`117`	`+ /* Is this looped even necessary? */`
`116`	`118`	`while (unlink(path))`
`117`	`119`	`{`
`118`	`120`	`if (errno != EACCES)`