Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 78c84ad

Browse files
committed
Because plpgsql's scanner uses %option case-insensitive, flex's results could
theoretically vary depending on what the compile-time locale setting is. Hence, force it to see LC_CTYPE=C to ensure consistent build results. (It's likely that this makes no difference in practice, since our specification for "identifier" surely includes both ends of any possible uppercase/lowercase pair anyway. But it should silence warnings about ambiguous character classes that are reported by some buildfarm members.)
1 parent 816ff27 commit 78c84ad

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/pl/plpgsql/src/Makefile

+6-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# Makefile for the plpgsql shared object
44
#
5-
# $PostgreSQL: pgsql/src/pl/plpgsql/src/Makefile,v 1.30 2007/02/09 15:56:00 petere Exp $
5+
# $PostgreSQL: pgsql/src/pl/plpgsql/src/Makefile,v 1.31 2007/07/15 22:18:24 tgl Exp $
66
#
77
#-------------------------------------------------------------------------
88

@@ -67,9 +67,13 @@ else
6767
@$(missing) bison $< $@
6868
endif
6969

70+
# Because we use %option case-insensitive, flex's results could vary
71+
# depending on what the compile-time locale setting is. Hence, force
72+
# it to see LC_CTYPE=C to ensure consistent build results.
73+
7074
$(srcdir)/pl_scan.c: scan.l
7175
ifdef FLEX
72-
$(FLEX) $(FLEXFLAGS) -o'$@' $<
76+
LC_CTYPE=C $(FLEX) $(FLEXFLAGS) -o'$@' $<
7377
else
7478
@$(missing) flex $< $@
7579
endif

0 commit comments

Comments
 (0)