Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 79c50ca

Browse files
committed
Update plannodes.h's comments about PlanRowMark.
The reference here to different physical column numbers in inherited UPDATE/DELETE plans is obsolete as of 86dc900; remove it. Also rework the text about inheritance cases to make it clearer.
1 parent 9e3b3ff commit 79c50ca

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/include/nodes/plannodes.h

+4-5
Original file line numberDiff line numberDiff line change
@@ -1086,9 +1086,9 @@ typedef enum RowMarkType
10861086
* When the planner discovers that a relation is the root of an inheritance
10871087
* tree, it sets isParent true, and adds an additional PlanRowMark to the
10881088
* list for each child relation (including the target rel itself in its role
1089-
* as a child). isParent is also set to true for the partitioned child
1090-
* relations, which are not scanned just like the root parent. The child
1091-
* entries have rti == child rel's RT index and prti == parent's RT index,
1089+
* as a child, if it is not a partitioned table). Any non-leaf partitioned
1090+
* child relations will also have entries with isParent = true. The child
1091+
* entries have rti == child rel's RT index and prti == top parent's RT index,
10921092
* and can therefore be recognized as children by the fact that prti != rti.
10931093
* The parent's allMarkTypes field gets the OR of (1<<markType) across all
10941094
* its children (this definition allows children to use different markTypes).
@@ -1109,8 +1109,7 @@ typedef enum RowMarkType
11091109
* means we needn't renumber rowmarkIds when flattening subqueries, which
11101110
* would require finding and renaming the resjunk columns as well.)
11111111
* Note this means that all tables in an inheritance hierarchy share the
1112-
* same resjunk column names. However, in an inherited UPDATE/DELETE the
1113-
* columns could have different physical column numbers in each subplan.
1112+
* same resjunk column names.
11141113
*/
11151114
typedef struct PlanRowMark
11161115
{

0 commit comments

Comments
 (0)