Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 7a3543c

Browse files
committed
Fix some comments referring to past features
Timestamp can only be an int64 since b9d092c, and support for WITH OIDS has been removed as of 578b229. Author: Justin Pryzby Discussion: https://postgr.es/m/20200612023709.GC14879@telsasoft.com
1 parent 3baa7e3 commit 7a3543c

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

src/backend/access/common/tupdesc.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -786,9 +786,7 @@ TupleDescInitEntryCollation(TupleDesc desc,
786786
*
787787
* Given a relation schema (list of ColumnDef nodes), build a TupleDesc.
788788
*
789-
* Note: the default assumption is no OIDs; caller may modify the returned
790-
* TupleDesc if it wants OIDs. Also, tdtypeid will need to be filled in
791-
* later on.
789+
* Note: tdtypeid will need to be filled in later on.
792790
*/
793791
TupleDesc
794792
BuildDescForRelation(List *schema)

src/backend/commands/tablecmds.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4829,12 +4829,11 @@ ATRewriteTables(AlterTableStmt *parsetree, List **wqueue, LOCKMODE lockmode,
48294829
continue;
48304830

48314831
/*
4832-
* If we change column data types or add/remove OIDs, the operation
4833-
* has to be propagated to tables that use this table's rowtype as a
4834-
* column type. tab->newvals will also be non-NULL in the case where
4835-
* we're adding a column with a default. We choose to forbid that
4836-
* case as well, since composite types might eventually support
4837-
* defaults.
4832+
* If we change column data types, the operation has to be propagated
4833+
* to tables that use this table's rowtype as a column type.
4834+
* tab->newvals will also be non-NULL in the case where we're adding a
4835+
* column with a default. We choose to forbid that case as well,
4836+
* since composite types might eventually support defaults.
48384837
*
48394838
* (Eventually we'll probably need to check for composite type
48404839
* dependencies even when we're just scanning the table without a
@@ -4853,8 +4852,7 @@ ATRewriteTables(AlterTableStmt *parsetree, List **wqueue, LOCKMODE lockmode,
48534852

48544853
/*
48554854
* We only need to rewrite the table if at least one column needs to
4856-
* be recomputed, we are adding/removing the OID column, or we are
4857-
* changing its persistence.
4855+
* be recomputed, or we are changing its persistence.
48584856
*
48594857
* There are two reasons for requiring a rewrite when changing
48604858
* persistence: on one hand, we need to ensure that the buffers

src/backend/utils/adt/selfuncs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4018,8 +4018,8 @@ estimate_multivariate_ndistinct(PlannerInfo *root, RelOptInfo *rel,
40184018
* to be treated separately.
40194019
*
40204020
* The several datatypes representing absolute times are all converted
4021-
* to Timestamp, which is actually a double, and then we just use that
4022-
* double value. Note this will give correct results even for the "special"
4021+
* to Timestamp, which is actually an int64, and then we promote that to
4022+
* a double. Note this will give correct results even for the "special"
40234023
* values of Timestamp, since those are chosen to compare correctly;
40244024
* see timestamp_cmp.
40254025
*

0 commit comments

Comments
 (0)