Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 8001cb7

Browse files
committed
Fix heap_page_prune() parameter order confusion introduced in dc7420c.
Both luckily and unluckily the passed values meant the same for all types. Luckily because that meant my confusion caused no harm, unluckily because otherwise the compiler might have warned... In passing, synchronize parameter names between definition and declaration. Reported-By: Peter Geoghegan <pg@bowt.ie> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/CAH2-Wz=L=nBoepQdH9b5Qd0nMvepFT2CnT6sjWvvpOXa=K8HVQ@mail.gmail.com
1 parent a975ff4 commit 8001cb7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/backend/access/heap/vacuumlazy.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,8 +1237,8 @@ lazy_scan_heap(Relation onerel, VacuumParams *params, LVRelStats *vacrelstats,
12371237
* We count tuples removed by the pruning step as removed by VACUUM
12381238
* (existing LP_DEAD line pointers don't count).
12391239
*/
1240-
tups_vacuumed += heap_page_prune(onerel, buf, vistest, false,
1241-
InvalidTransactionId, 0,
1240+
tups_vacuumed += heap_page_prune(onerel, buf, vistest,
1241+
InvalidTransactionId, 0, false,
12421242
&vacrelstats->latestRemovedXid,
12431243
&vacrelstats->offnum);
12441244

src/include/access/heapam.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,8 @@ struct GlobalVisState;
174174
extern void heap_page_prune_opt(Relation relation, Buffer buffer);
175175
extern int heap_page_prune(Relation relation, Buffer buffer,
176176
struct GlobalVisState *vistest,
177-
TransactionId limited_oldest_xmin,
178-
TimestampTz limited_oldest_ts,
177+
TransactionId old_snap_xmin,
178+
TimestampTz old_snap_ts_ts,
179179
bool report_stats, TransactionId *latestRemovedXid,
180180
OffsetNumber *off_loc);
181181
extern void heap_page_prune_execute(Buffer buffer,

0 commit comments

Comments
 (0)