pg_basebackup: Error message improvements.

robertmhaas · robertmhaas · commit 81f6bbe8ade8 · 2012-03-28T08:43:35.000-04:00
Fujii Masao
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -914,7 +914,7 @@ BaseBackup(void)
 	res = PQexec(conn, "IDENTIFY_SYSTEM");
 	if (PQresultStatus(res) != PGRES_TUPLES_OK)
 	{
-		fprintf(stderr, _("%s: could not identify system: %s\n"),
+		fprintf(stderr, _("%s: could not identify system: %s"),
 				progname, PQerrorMessage(conn));
 		disconnect_and_exit(1);
 	}
@@ -1049,8 +1049,8 @@ BaseBackup(void)
 	res = PQgetResult(conn);
 	if (PQresultStatus(res) != PGRES_TUPLES_OK)
 	{
-		fprintf(stderr, _("%s: could not get WAL end position from server\n"),
-				progname);
+		fprintf(stderr, _("%s: could not get WAL end position from server: %s"),
+				progname, PQerrorMessage(conn));
 		disconnect_and_exit(1);
 	}
 	if (PQntuples(res) != 1)

Original file line number	Diff line number	Diff line change
`@@ -914,7 +914,7 @@ BaseBackup(void)`
`914`	`914`	`res = PQexec(conn, "IDENTIFY_SYSTEM");`
`915`	`915`	`if (PQresultStatus(res) != PGRES_TUPLES_OK)`
`916`	`916`	`{`
`917`		`- fprintf(stderr, _("%s: could not identify system: %s\n"),`
	`917`	`+ fprintf(stderr, _("%s: could not identify system: %s"),`
`918`	`918`	`progname, PQerrorMessage(conn));`
`919`	`919`	`disconnect_and_exit(1);`
`920`	`920`	`}`
`@@ -1049,8 +1049,8 @@ BaseBackup(void)`
`1049`	`1049`	`res = PQgetResult(conn);`
`1050`	`1050`	`if (PQresultStatus(res) != PGRES_TUPLES_OK)`
`1051`	`1051`	`{`
`1052`		`- fprintf(stderr, _("%s: could not get WAL end position from server\n"),`
`1053`		`- progname);`
	`1052`	`+ fprintf(stderr, _("%s: could not get WAL end position from server: %s"),`
	`1053`	`+ progname, PQerrorMessage(conn));`
`1054`	`1054`	`disconnect_and_exit(1);`
`1055`	`1055`	`}`
`1056`	`1056`	`if (PQntuples(res) != 1)`