Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 83e3239

Browse files
Standardize one aspect of rmgr desc output.
Bring heap and hash rmgr desc output in line with nbtree and GiST desc output by using the name latestRemovedXid for all fields that output the contents of the latestRemovedXid field from the WAL record's C struct (stop using local variants). This seems like a clear improvement because latestRemovedXid is a symbol name that already appears across many different source files, and so is probably much more recognizable. Discussion: https://postgr.es/m/CAH2-Wzkt_Rs4VqPSCk87nyjPAAEmWL8STU9zgET_83EF5YfrLw@mail.gmail.com
1 parent cd357c7 commit 83e3239

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/backend/access/rmgrdesc/hashdesc.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ hash_desc(StringInfo buf, XLogReaderState *record)
113113
{
114114
xl_hash_vacuum_one_page *xlrec = (xl_hash_vacuum_one_page *) rec;
115115

116-
appendStringInfo(buf, "ntuples %d, latest removed xid %u",
116+
appendStringInfo(buf, "ntuples %d, latestRemovedXid %u",
117117
xlrec->ntuples,
118118
xlrec->latestRemovedXid);
119119
break;

src/backend/access/rmgrdesc/heapdesc.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ heap2_desc(StringInfo buf, XLogReaderState *record)
125125
{
126126
xl_heap_clean *xlrec = (xl_heap_clean *) rec;
127127

128-
appendStringInfo(buf, "remxid %u", xlrec->latestRemovedXid);
128+
appendStringInfo(buf, "latestRemovedXid %u", xlrec->latestRemovedXid);
129129
}
130130
else if (info == XLOG_HEAP2_FREEZE_PAGE)
131131
{
@@ -138,7 +138,7 @@ heap2_desc(StringInfo buf, XLogReaderState *record)
138138
{
139139
xl_heap_cleanup_info *xlrec = (xl_heap_cleanup_info *) rec;
140140

141-
appendStringInfo(buf, "remxid %u", xlrec->latestRemovedXid);
141+
appendStringInfo(buf, "latestRemovedXid %u", xlrec->latestRemovedXid);
142142
}
143143
else if (info == XLOG_HEAP2_VISIBLE)
144144
{

0 commit comments

Comments
 (0)