Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 8654246

Browse files
committed
Further code review of port/simd.h
Add missing declaration per existing style, and fix a couple typos. Nathan Bossart and Julien Rouhaud Discussion: https://www.postgresql.org/message-id/20220829171712.GA509233%40nathanxps13 Discussion: https://www.postgresql.org/message-id/20220830022636.qrcbcecmhztbxrwa%40jrouhaud
1 parent 9887dd3 commit 8654246

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/include/port/simd.h

+5-2
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,9 @@ static inline bool vector8_has(const Vector8 v, const uint8 c);
7777
static inline bool vector8_has_zero(const Vector8 v);
7878
static inline bool vector8_has_le(const Vector8 v, const uint8 c);
7979
static inline bool vector8_is_highbit_set(const Vector8 v);
80+
#ifndef USE_NO_SIMD
81+
static inline bool vector32_is_highbit_set(const Vector32 v);
82+
#endif
8083

8184
/* arithmetic operations */
8285
static inline Vector8 vector8_or(const Vector8 v1, const Vector8 v2);
@@ -88,7 +91,7 @@ static inline Vector8 vector8_ssub(const Vector8 v1, const Vector8 v2);
8891
/*
8992
* comparisons between vectors
9093
*
91-
* Note: These return a vector rather than booloan, which is why we don't
94+
* Note: These return a vector rather than boolean, which is why we don't
9295
* have non-SIMD implementations.
9396
*/
9497
#ifndef USE_NO_SIMD
@@ -275,7 +278,7 @@ vector8_is_highbit_set(const Vector8 v)
275278
}
276279

277280
/*
278-
* Exactly like vector32_is_highbit_set except for the input type, so it
281+
* Exactly like vector8_is_highbit_set except for the input type, so it
279282
* looks at each byte separately.
280283
*
281284
* XXX x86 uses the same underlying type for 8-bit, 16-bit, and 32-bit

0 commit comments

Comments
 (0)