Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 87a174c

Browse files
committed
Fix broken XML formatting in EXPLAIN output for incremental sorts.
The ExplainCloseGroup arguments for incremental sort usage data didn't match the corresponding ExplainOpenGroup. This only matters for XML-format output, which is probably why we'd not noticed. Daniel Gustafsson, per bug #16683 from Frits Jalvingh Discussion: https://postgr.es/m/16683-8005033324ad34e9@postgresql.org
1 parent 83d727e commit 87a174c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/backend/commands/explain.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -2827,7 +2827,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
28272827
ExplainPropertyInteger("Peak Sort Space Used", "kB",
28282828
groupInfo->maxMemorySpaceUsed, es);
28292829

2830-
ExplainCloseGroup("Sort Spaces", memoryName.data, true, es);
2830+
ExplainCloseGroup("Sort Space", memoryName.data, true, es);
28312831
}
28322832
if (groupInfo->maxDiskSpaceUsed > 0)
28332833
{
@@ -2844,7 +2844,7 @@ show_incremental_sort_group_info(IncrementalSortGroupInfo *groupInfo,
28442844
ExplainPropertyInteger("Peak Sort Space Used", "kB",
28452845
groupInfo->maxDiskSpaceUsed, es);
28462846

2847-
ExplainCloseGroup("Sort Spaces", diskName.data, true, es);
2847+
ExplainCloseGroup("Sort Space", diskName.data, true, es);
28482848
}
28492849

28502850
ExplainCloseGroup("Incremental Sort Groups", groupName.data, true, es);

0 commit comments

Comments
 (0)