Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 89988ac

Browse files
committed
Fix further fallout from EXPLAIN ANALYZE BUFFERS change
c2a4078 adjusted EXPLAIN ANALYZE to default the BUFFERS to ON. This (hopefully) fixes the last remaining issue with regression test failures with -D RELCACHE_FORCE_RELEASE -D CATCACHE_FORCE_RELEASE builds, where the planner accesses more buffers due to the cold caches. Discussion: https://postgr.es/m/CAApHDvqLdzgz77JsE-yTki3w9UiKQ-uTMLRctazcu+99-ips3g@mail.gmail.com
1 parent e8d5929 commit 89988ac

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

contrib/pg_stat_statements/expected/level_tracking.out

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -903,13 +903,13 @@ SELECT pg_stat_statements_reset() IS NOT NULL AS t;
903903
t
904904
(1 row)
905905

906-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100;
906+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
907907
QUERY PLAN
908908
--------------------------------
909909
Result (actual rows=1 loops=1)
910910
(1 row)
911911

912-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
912+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
913913
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
914914
QUERY PLAN
915915
-----------------------------------------------------
@@ -918,11 +918,11 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
918918

919919
SELECT toplevel, calls, query FROM pg_stat_statements
920920
ORDER BY query COLLATE "C";
921-
toplevel | calls | query
922-
----------+-------+-----------------------------------------------------------------
923-
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) +
921+
toplevel | calls | query
922+
----------+-------+------------------------------------------------------------------------------
923+
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) +
924924
| | DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab
925-
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT $1
925+
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT $1
926926
f | 1 | SELECT $1
927927
f | 1 | SELECT * FROM stats_track_tab
928928
t | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t
@@ -936,13 +936,13 @@ SELECT pg_stat_statements_reset() IS NOT NULL AS t;
936936
t
937937
(1 row)
938938

939-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100;
939+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
940940
QUERY PLAN
941941
--------------------------------
942942
Result (actual rows=1 loops=1)
943943
(1 row)
944944

945-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
945+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
946946
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
947947
QUERY PLAN
948948
-----------------------------------------------------
@@ -951,11 +951,11 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
951951

952952
SELECT toplevel, calls, query FROM pg_stat_statements
953953
ORDER BY query COLLATE "C";
954-
toplevel | calls | query
955-
----------+-------+-----------------------------------------------------------------
956-
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) +
954+
toplevel | calls | query
955+
----------+-------+------------------------------------------------------------------------------
956+
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) +
957957
| | DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab
958-
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT $1
958+
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT $1
959959
t | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t
960960
(3 rows)
961961

contrib/pg_stat_statements/sql/level_tracking.sql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,17 +175,17 @@ SELECT toplevel, calls, query FROM pg_stat_statements
175175
-- Explain analyze, all-level tracking.
176176
SET pg_stat_statements.track = 'all';
177177
SELECT pg_stat_statements_reset() IS NOT NULL AS t;
178-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100;
179-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
178+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
179+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
180180
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
181181
SELECT toplevel, calls, query FROM pg_stat_statements
182182
ORDER BY query COLLATE "C";
183183

184184
-- Explain analyze, top tracking.
185185
SET pg_stat_statements.track = 'top';
186186
SELECT pg_stat_statements_reset() IS NOT NULL AS t;
187-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100;
188-
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
187+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
188+
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
189189
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
190190
SELECT toplevel, calls, query FROM pg_stat_statements
191191
ORDER BY query COLLATE "C";

0 commit comments

Comments
 (0)