c89 compat and fix few warnings

Author: kelvich

src/commit.c

@@ -207,6 +207,7 @@ MtmTwoPhaseCommit()
 	char		gid[GIDSIZE];
 	mtm_msg		messages[MTM_MAX_NODES];
 	int			n_messages;
+	int			i;
 
 	if (!MtmTx.contains_persistent_ddl && !MtmTx.contains_dml)
 		return false;
@@ -264,7 +265,7 @@ MtmTwoPhaseCommit()
 	gather(participants, messages, &n_messages);
 	dmq_stream_unsubscribe(stream);
 
-	for (int i = 0; i < n_messages; i++)
+	for (i = 0; i < n_messages; i++)
 	{
 		MtmMessageCode status = pq_getmsgbyte(messages[i].message);
 
@@ -349,6 +350,7 @@ MtmExplicitPrepare(char *gid)
 	char	stream[DMQ_NAME_MAXLEN];
 	mtm_msg		messages[MTM_MAX_NODES];
 	int			n_messages;
+	int			i;
 
 	xid = GetTopTransactionId();
 	sprintf(stream, "xid" XID_FMT, xid);
@@ -369,7 +371,7 @@ MtmExplicitPrepare(char *gid)
 	gather(participants, messages, &n_messages);
 	dmq_stream_unsubscribe(stream);
 
-	for (int i = 0; i < n_messages; i++)
+	for (i = 0; i < n_messages; i++)
 	{
 		MtmMessageCode status = pq_getmsgbyte(messages[i].message);
 

src/pglogical_apply.c

@@ -905,7 +905,6 @@ process_remote_commit(StringInfo in, GlobalTransactionId *current_gtid, MtmRecei
 	uint8 		event;
 	XLogRecPtr	end_lsn;
 	XLogRecPtr	origin_lsn;
-	XLogRecPtr	commit_lsn;
 	int         origin_node;
 	char        gid[GIDSIZE];
 
@@ -916,7 +915,7 @@ process_remote_commit(StringInfo in, GlobalTransactionId *current_gtid, MtmRecei
 	MtmReplicationNodeId = pq_getmsgbyte(in);
 
 	/* read fields */
-	commit_lsn = pq_getmsgint64(in); /* commit_lsn */
+	pq_getmsgint64(in); /* commit_lsn */
 	end_lsn = pq_getmsgint64(in); /* end_lsn */
 	replorigin_session_origin_timestamp = pq_getmsgint64(in); /* commit_time */
 
@@ -1369,7 +1368,7 @@ process_remote_delete(StringInfo s, Relation rel)
 	EState	   *estate;
 	TupleData   oldtup;
 	TupleTableSlot *oldslot;
-	Oid			idxoid;
+	Oid			idxoid = InvalidOid;
 	Relation	idxrel;
 	TupleDesc   tupDesc = RelationGetDescr(rel);
 	ScanKeyData skey[INDEX_MAX_KEYS];