Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 8cd44db

Browse files
committed
Update comments about index parallel builds
Commit b437571 allowed parallel builds for BRIN, but left behind two comments claiming only btree indexes support parallel builds. Reported by Egor Rogov, along with similar issues in SGML docs. Backpatch to 17, where parallel builds for BRIN were introduced. Reported-by: Egor Rogov Backpatch-through: 17 Discussion: https://postgr.es/m/114e2d5d-125e-07d8-94aa-5ad175fb7443@postgrespro.ru
1 parent fb1a188 commit 8cd44db

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/backend/catalog/index.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2989,7 +2989,7 @@ index_build(Relation heapRelation,
29892989

29902990
/*
29912991
* Determine worker process details for parallel CREATE INDEX. Currently,
2992-
* only btree has support for parallel builds.
2992+
* only btree and BRIN have support for parallel builds.
29932993
*
29942994
* Note that planner considers parallel safety for us.
29952995
*/

src/backend/optimizer/plan/planner.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6758,7 +6758,8 @@ plan_cluster_use_sort(Oid tableOid, Oid indexOid)
67586758
* CREATE INDEX should request for use
67596759
*
67606760
* tableOid is the table on which the index is to be built. indexOid is the
6761-
* OID of an index to be created or reindexed (which must be a btree index).
6761+
* OID of an index to be created or reindexed (which must be an index with
6762+
* support for parallel builds - currently btree or BRIN).
67626763
*
67636764
* Return value is the number of parallel worker processes to request. It
67646765
* may be unsafe to proceed if this is 0. Note that this does not include the

0 commit comments

Comments
 (0)