Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 8dc3d68

Browse files
committed
Improve comments about USE_VALGRIND in pg_config_manual.h.
These comments left the impression that USE_VALGRIND isn't really essential for valgrind testing. But that's wrong, as I learned the hard way today. Discussion: https://postgr.es/m/512778.1620588546@sss.pgh.pa.us
1 parent 92c4c26 commit 8dc3d68

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/include/pg_config_manual.h

+7-1
Original file line numberDiff line numberDiff line change
@@ -279,12 +279,18 @@
279279
* enables detection of buffer accesses that take place without holding a
280280
* buffer pin (or without holding a buffer lock in the case of index access
281281
* methods that superimpose their own custom client requests on top of the
282-
* generic bufmgr.c requests). See also src/tools/valgrind.supp.
282+
* generic bufmgr.c requests).
283283
*
284284
* "make installcheck" is significantly slower under Valgrind. The client
285285
* requests fall in hot code paths, so USE_VALGRIND slows execution by a few
286286
* percentage points even when not run under Valgrind.
287287
*
288+
* Do not try to test the server under Valgrind without having built the
289+
* server with USE_VALGRIND; else you will get false positives from sinval
290+
* messaging (see comments in AddCatcacheInvalidationMessage). It's also
291+
* important to use the suppression file src/tools/valgrind.supp to
292+
* exclude other known false positives.
293+
*
288294
* You should normally use MEMORY_CONTEXT_CHECKING with USE_VALGRIND;
289295
* instrumentation of repalloc() is inferior without it.
290296
*/

0 commit comments

Comments
 (0)