Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 8efe710

Browse files
committed
Probe only 127.0.0.1 when looking for ports on Unix.
Commit c098509, later adjusted by commit 4ab02e8, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some corporate firewall software. Switch back to probing just 127.0.0.1 on non-Windows systems. Back-patch to 9.6, like the earlier changes. Discussion: https://postgr.es/m/CA%2BhUKG%2B21EPwfgs4m%2BtqyRtbVqkOUvP8QQ8sWk9%2Bh55Aub1H3A%40mail.gmail.com
1 parent 098344b commit 8efe710

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/test/perl/PostgresNode.pm

+4-3
Original file line numberDiff line numberDiff line change
@@ -1101,14 +1101,15 @@ sub get_new_node
11011101
# This seems like a good idea on Unixen as well, even though we don't
11021102
# ask the postmaster to open a TCP port on Unix. On Non-Linux,
11031103
# non-Windows kernels, binding to 127.0.0.1/24 addresses other than
1104-
# 127.0.0.1 fails with EADDRNOTAVAIL.
1104+
# 127.0.0.1 might fail with EADDRNOTAVAIL. Binding to 0.0.0.0 is
1105+
# unnecessary on non-Windows systems.
11051106
#
11061107
# XXX A port available now may become unavailable by the time we start
11071108
# the postmaster.
11081109
if ($found == 1)
11091110
{
1110-
foreach my $addr (qw(127.0.0.1 0.0.0.0),
1111-
$use_tcp ? qw(127.0.0.2 127.0.0.3) : ())
1111+
foreach my $addr (qw(127.0.0.1),
1112+
$use_tcp ? qw(127.0.0.2 127.0.0.3 0.0.0.0) : ())
11121113
{
11131114
can_bind($addr, $port) or $found = 0;
11141115
}

0 commit comments

Comments
 (0)