Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 901a9d5

Browse files
committed
Remove unportable test
The ssl test "IPv4 host with CIDR mask does not match" apparently has a portability problem. Some operating systems don't reject the host name specification "192.0.2.1/32" as an IP address, and that is then later rejected when the SNI is set, which results in a different error message that the test is supposed to verify. The value of the test has been questioned in the discussion, and it was suggested that removing it would be an acceptable fix, so that's what this is doing. Reported-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Bug: #17522 Discussion: https://www.postgresql.org/message-id/flat/17522-bfcd5c603b5f4daa%40postgresql.org
1 parent 1f50918 commit 901a9d5

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/test/ssl/t/001_ssltests.pl

-7
Original file line numberDiff line numberDiff line change
@@ -333,13 +333,6 @@ sub switch_server_cert
333333
qr/\Qserver certificate for "192.0.2.1" (and 1 other name) does not match host name "192.0.2.2"\E/
334334
);
335335

336-
$node->connect_fails(
337-
"$common_connstr host=192.0.2.1/32",
338-
"IPv4 host with CIDR mask does not match",
339-
expected_stderr =>
340-
qr/\Qserver certificate for "192.0.2.1" (and 1 other name) does not match host name "192.0.2.1\/32"\E/
341-
);
342-
343336
$node->connect_ok("$common_connstr host=2001:DB8::1",
344337
"host matching an IPv6 address (Subject Alternative Name 2)");
345338

0 commit comments

Comments
 (0)