Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 91416f4

Browse files
committed
doc: Fix description of replication command CREATE_REPLICATION_SLOT
The output plugin name is a mandatory option when creating a logical slot, but the grammar documented was not described as such. While on it, fix two comments in repl_gram.y to show that TEMPORARY is an optional grammar choice. Author: Ayaki Tachikake Discussion: https://postgr.es/m/OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.com Backpatch-through: 15
1 parent 42d203c commit 91416f4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

doc/src/sgml/protocol.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1987,7 +1987,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
19871987
</varlistentry>
19881988

19891989
<varlistentry id="protocol-replication-create-replication-slot" xreflabel="CREATE_REPLICATION_SLOT">
1990-
<term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
1990+
<term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> <replaceable class="parameter">output_plugin</replaceable> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
19911991
<indexterm><primary>CREATE_REPLICATION_SLOT</primary></indexterm>
19921992
</term>
19931993
<listitem>

src/backend/replication/repl_gram.y

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ base_backup:
174174
;
175175

176176
create_replication_slot:
177-
/* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options] */
177+
/* CREATE_REPLICATION_SLOT slot [TEMPORARY] PHYSICAL [options] */
178178
K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_PHYSICAL create_slot_options
179179
{
180180
CreateReplicationSlotCmd *cmd;
@@ -185,7 +185,7 @@ create_replication_slot:
185185
cmd->options = $5;
186186
$$ = (Node *) cmd;
187187
}
188-
/* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options] */
188+
/* CREATE_REPLICATION_SLOT slot [TEMPORARY] LOGICAL plugin [options] */
189189
| K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_LOGICAL IDENT create_slot_options
190190
{
191191
CreateReplicationSlotCmd *cmd;

0 commit comments

Comments
 (0)