Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 91d395f

Browse files
committed
Re-enable TAP tests of pg_receivewal for ZLIB on Windows
This is a revert of 6cea447, that disabled those tests temporarily on Windows due to failures with bowerbird where gzflush() would fail when executed on a freshly-opened compressed and partial segment. This problem should be taken care of now thanks to 7fbe0c8, so let's see what the buildfarm has to say on Windows for those tests. Discussion: https://postgr.es/m/YPDLz2x3o1aX2wRh@paquier.xyz
1 parent 7fbe0c8 commit 91d395f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/bin/pg_basebackup/t/020_pg_receivewal.pl

+3-5
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,11 @@
7272
my @partial_wals = glob "$stream_dir/*\.partial";
7373
is(scalar(@partial_wals), 1, "one partial WAL segment was created");
7474

75-
# Check ZLIB compression if available. On Windows, some old versions
76-
# of zlib can cause some instabilities with this test, so disable it
77-
# for now.
75+
# Check ZLIB compression if available.
7876
SKIP:
7977
{
80-
skip "postgres was not built with ZLIB support, or Windows is involved", 5
81-
if (!check_pg_config("#define HAVE_LIBZ 1") || $windows_os);
78+
skip "postgres was not built with ZLIB support", 5
79+
if (!check_pg_config("#define HAVE_LIBZ 1"));
8280

8381
# Generate more WAL worth one completed, compressed, segment.
8482
$primary->psql('postgres', 'SELECT pg_switch_wal();');

0 commit comments

Comments
 (0)