Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 92155e1

Browse files
committed
Fix incorrect TAP test ordering
Using a test function before a possible skip_all is incorrect. If the skip_all is called, the test output will become incorrect and the test file will fail. a4f23f9 introduced a new test before skip_all. After discussion, this doesn't really need to be a test. Instead, we just bail out if the condition is not satisfied. Discussion: https://www.postgresql.org/message-id/af5567a1-aea6-fbdb-7e4b-d1e23a43c43b@enterprisedb.com
1 parent 1d70fb4 commit 92155e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bin/pg_amcheck/t/004_verify_heapam.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ sub write_tuple
340340
FROM heap_page_items(get_raw_page('test', 'main', 0))
341341
)
342342
);
343-
is(scalar @lp_off, $ROWCOUNT, "acquired row offsets");
343+
scalar @lp_off == $ROWCOUNT or BAIL_OUT("row offset counts mismatch");
344344

345345
# Sanity check that our 'test' table on disk layout matches expectations. If
346346
# this is not so, we will have to skip the test until somebody updates the test

0 commit comments

Comments
 (0)