Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 93507e6

Browse files
committed
Adjust some more comments for WITH OIDS removal.
I missed these in 578b229. Author: Andres Freund
1 parent 8eb4a93 commit 93507e6

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

src/backend/access/heap/heapam.c

+8-11
Original file line numberDiff line numberDiff line change
@@ -2451,11 +2451,10 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)
24512451
* The BulkInsertState object (if any; bistate can be NULL for default
24522452
* behavior) is also just passed through to RelationGetBufferForTuple.
24532453
*
2454-
* The return value is the OID assigned to the tuple (either here or by the
2455-
* caller), or InvalidOid if no OID. The header fields of *tup are updated
2456-
* to match the stored tuple; in particular tup->t_self receives the actual
2457-
* TID where the tuple was stored. But note that any toasting of fields
2458-
* within the tuple data is NOT reflected into *tup.
2454+
* On return the header fields of *tup are updated to match the stored tuple;
2455+
* in particular tup->t_self receives the actual TID where the tuple was
2456+
* stored. But note that any toasting of fields within the tuple data is NOT
2457+
* reflected into *tup.
24592458
*/
24602459
void
24612460
heap_insert(Relation relation, HeapTuple tup, CommandId cid,
@@ -2468,8 +2467,7 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
24682467
bool all_visible_cleared = false;
24692468

24702469
/*
2471-
* Fill in tuple header fields, assign an OID, and toast the tuple if
2472-
* necessary.
2470+
* Fill in tuple header fields and toast the tuple if necessary.
24732471
*
24742472
* Note: below this point, heaptup is the data we actually intend to store
24752473
* into the relation; tup is the caller's original untoasted data.
@@ -2635,10 +2633,9 @@ heap_insert(Relation relation, HeapTuple tup, CommandId cid,
26352633

26362634
/*
26372635
* Subroutine for heap_insert(). Prepares a tuple for insertion. This sets the
2638-
* tuple header fields, assigns an OID, and toasts the tuple if necessary.
2639-
* Returns a toasted version of the tuple if it was toasted, or the original
2640-
* tuple if not. Note that in any case, the header fields are also set in
2641-
* the original tuple.
2636+
* tuple header fields and toasts the tuple if necessary. Returns a toasted
2637+
* version of the tuple if it was toasted, or the original tuple if not. Note
2638+
* that in any case, the header fields are also set in the original tuple.
26422639
*/
26432640
static HeapTuple
26442641
heap_prepare_insert(Relation relation, HeapTuple tup, TransactionId xid,

0 commit comments

Comments
 (0)