Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 9356e43

Browse files
tglsfdctglsfdc
committed
Doc: fix assorted misstatements of fact in catalog & system view docs.
I made up a very crude hack to compare the docs with reality (as embodied in the system catalogs) ... and indeed they don't match everywhere. Missing oid columns, wrong data types, wrong "references" links, columns listed in the wrong order. None of this seems quite important enough to back-patch.
1 parent 96d175e commit 9356e43

File tree

3 files changed

+65
-30
lines changed

3 files changed

+65
-30
lines changed

‎doc/src/sgml/catalogs.sgml

Lines changed: 56 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3312,6 +3312,13 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
33123312
</thead>
33133313

33143314
<tbody>
3315+
<row>
3316+
<entry><structfield>oid</structfield></entry>
3317+
<entry><type>oid</type></entry>
3318+
<entry></entry>
3319+
<entry>Row identifier</entry>
3320+
</row>
3321+
33153322
<row>
33163323
<entry><structfield>evtname</structfield></entry>
33173324
<entry><type>name</type></entry>
@@ -4879,7 +4886,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
48794886
<row>
48804887
<entry><structfield>partcollation</structfield></entry>
48814888
<entry><type>oidvector</type></entry>
4882-
<entry><literal><link linkend="catalog-pg-opclass"><structname>pg_opclass</structname></link>.oid</literal></entry>
4889+
<entry><literal><link linkend="catalog-pg-collation"><structname>pg_collation</structname></link>.oid</literal></entry>
48834890
<entry>
48844891
For each column in the partition key, this contains the OID of the
48854892
collation to use for partitioning, or zero if the column is not
@@ -4938,6 +4945,13 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
49384945
</thead>
49394946

49404947
<tbody>
4948+
<row>
4949+
<entry><structfield>oid</structfield></entry>
4950+
<entry><type>oid</type></entry>
4951+
<entry></entry>
4952+
<entry>Row identifier</entry>
4953+
</row>
4954+
49414955
<row>
49424956
<entry><structfield>polname</structfield></entry>
49434957
<entry><type>name</type></entry>
@@ -5480,6 +5494,13 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
54805494
</thead>
54815495

54825496
<tbody>
5497+
<row>
5498+
<entry><structfield>oid</structfield></entry>
5499+
<entry><type>oid</type></entry>
5500+
<entry></entry>
5501+
<entry>Row identifier</entry>
5502+
</row>
5503+
54835504
<row>
54845505
<entry><structfield>prpubid</structfield></entry>
54855506
<entry><type>oid</type></entry>
@@ -6432,6 +6453,13 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
64326453

64336454
<tbody>
64346455

6456+
<row>
6457+
<entry><structfield>oid</structfield></entry>
6458+
<entry><type>oid</type></entry>
6459+
<entry></entry>
6460+
<entry>Row identifier</entry>
6461+
</row>
6462+
64356463
<row>
64366464
<entry><structfield>stxrelid</structfield></entry>
64376465
<entry><type>oid</type></entry>
@@ -6677,16 +6705,6 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
66776705
<entry>If true, the subscription is enabled and should be replicating.</entry>
66786706
</row>
66796707

6680-
<row>
6681-
<entry><structfield>subsynccommit</structfield></entry>
6682-
<entry><type>text</type></entry>
6683-
<entry></entry>
6684-
<entry>
6685-
Contains the value of the <varname>synchronous_commit</varname>
6686-
setting for the subscription workers.
6687-
</entry>
6688-
</row>
6689-
66906708
<row>
66916709
<entry><structfield>subconninfo</structfield></entry>
66926710
<entry><type>text</type></entry>
@@ -6702,6 +6720,16 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
67026720
for local replication origin name.</entry>
67036721
</row>
67046722

6723+
<row>
6724+
<entry><structfield>subsynccommit</structfield></entry>
6725+
<entry><type>text</type></entry>
6726+
<entry></entry>
6727+
<entry>
6728+
Contains the value of the <varname>synchronous_commit</varname>
6729+
setting for the subscription workers.
6730+
</entry>
6731+
</row>
6732+
67056733
<row>
67066734
<entry><structfield>subpublications</structfield></entry>
67076735
<entry><type>text[]</type></entry>
@@ -6894,6 +6922,13 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
68946922
</thead>
68956923

68966924
<tbody>
6925+
<row>
6926+
<entry><structfield>oid</structfield></entry>
6927+
<entry><type>oid</type></entry>
6928+
<entry></entry>
6929+
<entry>Row identifier</entry>
6930+
</row>
6931+
68976932
<row>
68986933
<entry><structfield>trftype</structfield></entry>
68996934
<entry><type>oid</type></entry>
@@ -9447,7 +9482,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
94479482
<entry>Name of policy</entry>
94489483
</row>
94499484
<row>
9450-
<entry><structfield>polpermissive</structfield></entry>
9485+
<entry><structfield>permissive</structfield></entry>
94519486
<entry><type>text</type></entry>
94529487
<entry></entry>
94539488
<entry>Is the policy permissive or restrictive?</entry>
@@ -9844,7 +9879,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
98449879

98459880
<row>
98469881
<entry><structfield>database</structfield></entry>
9847-
<entry><type>text</type></entry>
9882+
<entry><type>name</type></entry>
98489883
<entry><literal><link linkend="catalog-pg-database"><structname>pg_database</structname></link>.datname</literal></entry>
98499884
<entry>The name of the database this slot is associated with, or
98509885
null. Only logical slots have an associated database.</entry>
@@ -10297,7 +10332,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1029710332
<row>
1029810333
<entry><structfield>data_type</structfield></entry>
1029910334
<entry><type>regtype</type></entry>
10300-
<entry><literal><link linkend="catalog-pg-authid"><structname>pg_type</structname></link>.oid</literal></entry>
10335+
<entry><literal><link linkend="catalog-pg-type"><structname>pg_type</structname></link>.oid</literal></entry>
1030110336
<entry>Data type of the sequence</entry>
1030210337
</row>
1030310338
<row>
@@ -11075,8 +11110,8 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1107511110

1107611111
<row>
1107711112
<entry><structfield>statistics_owner</structfield></entry>
11078-
<entry><type>oid</type></entry>
11079-
<entry><literal><link linkend="catalog-pg-authid"><structname>pg_authid</structname></link>.oid</literal></entry>
11113+
<entry><type>name</type></entry>
11114+
<entry><literal><link linkend="catalog-pg-authid"><structname>pg_authid</structname></link>.rolname</literal></entry>
1108011115
<entry>Owner of the extended statistics</entry>
1108111116
</row>
1108211117

@@ -11089,7 +11124,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1108911124

1109011125
<row>
1109111126
<entry><structfield>kinds</structfield></entry>
11092-
<entry><type>text[]</type></entry>
11127+
<entry><type>char[]</type></entry>
1109311128
<entry></entry>
1109411129
<entry>Types of extended statistics enabled for this record</entry>
1109511130
</row>
@@ -11120,7 +11155,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1112011155

1112111156
<row>
1112211157
<entry><structfield>most_common_vals</structfield></entry>
11123-
<entry><type>anyarray</type></entry>
11158+
<entry><type>text[]</type></entry>
1112411159
<entry></entry>
1112511160
<entry>
1112611161
A list of the most common combinations of values in the columns.
@@ -11130,7 +11165,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1113011165

1113111166
<row>
1113211167
<entry><structfield>most_common_val_nulls</structfield></entry>
11133-
<entry><type>anyarray</type></entry>
11168+
<entry><type>bool[]</type></entry>
1113411169
<entry></entry>
1113511170
<entry>
1113611171
A list of NULL flags for the most common combinations of values.
@@ -11140,7 +11175,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1114011175

1114111176
<row>
1114211177
<entry><structfield>most_common_freqs</structfield></entry>
11143-
<entry><type>real[]</type></entry>
11178+
<entry><type>float8[]</type></entry>
1114411179
<entry></entry>
1114511180
<entry>
1114611181
A list of the frequencies of the most common combinations,
@@ -11151,7 +11186,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1115111186

1115211187
<row>
1115311188
<entry><structfield>most_common_base_freqs</structfield></entry>
11154-
<entry><type>real[]</type></entry>
11189+
<entry><type>float8[]</type></entry>
1115511190
<entry></entry>
1115611191
<entry>
1115711192
A list of the base frequencies of the most common combinations,

‎doc/src/sgml/information_schema.sgml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4498,7 +4498,7 @@ ORDER BY c.ordinal_position;
44984498

44994499
<row>
45004500
<entry><literal>result_cast_char_octet_length</literal></entry>
4501-
<entry><type>character_data</type></entry>
4501+
<entry><type>cardinal_number</type></entry>
45024502
<entry>Applies to a feature not available in <productname>PostgreSQL</productname></entry>
45034503
</row>
45044504

@@ -4558,7 +4558,7 @@ ORDER BY c.ordinal_position;
45584558

45594559
<row>
45604560
<entry><literal>result_cast_datetime_precision</literal></entry>
4561-
<entry><type>character_data</type></entry>
4561+
<entry><type>cardinal_number</type></entry>
45624562
<entry>Applies to a feature not available in <productname>PostgreSQL</productname></entry>
45634563
</row>
45644564

‎doc/src/sgml/monitoring.sgml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2043,11 +2043,6 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
20432043
<entry><type>timestamp with time zone</type></entry>
20442044
<entry>Send time of last reply message received from standby server</entry>
20452045
</row>
2046-
<row>
2047-
<entry><structfield>spill_bytes</structfield></entry>
2048-
<entry><type>bigint</type></entry>
2049-
<entry>Amount of decoded transaction data spilled to disk.</entry>
2050-
</row>
20512046
<row>
20522047
<entry><structfield>spill_txns</structfield></entry>
20532048
<entry><type>bigint</type></entry>
@@ -2063,6 +2058,11 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
20632058
may get spilled repeatedly, and this counter gets incremented on every
20642059
such invocation.</entry>
20652060
</row>
2061+
<row>
2062+
<entry><structfield>spill_bytes</structfield></entry>
2063+
<entry><type>bigint</type></entry>
2064+
<entry>Amount of decoded transaction data spilled to disk.</entry>
2065+
</row>
20662066
</tbody>
20672067
</tgroup>
20682068
</table>
@@ -2242,7 +2242,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
22422242
</row>
22432243
<row>
22442244
<entry><structfield>subname</structfield></entry>
2245-
<entry><type>text</type></entry>
2245+
<entry><type>name</type></entry>
22462246
<entry>Name of the subscription</entry>
22472247
</row>
22482248
<row>
@@ -3294,7 +3294,7 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
32943294
<tbody>
32953295
<row>
32963296
<entry><structfield>name</structfield></entry>
3297-
<entry><type>name</type></entry>
3297+
<entry><type>text</type></entry>
32983298
<entry>name of the SLRU</entry>
32993299
</row>
33003300
<row>

0 commit comments

Comments
 (0)