Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 93a0bf2

Browse files
committed
Set pg_setting.pending_restart when pertinent config lines are removed
This changes the behavior of examining the pg_file_settings view after changing a config option that requires restart. The user needs to know that any change of such options does not take effect until a restart, and this worked correctly if the line is edited without removing it. However, for the case where the line is removed altogether, the flag doesn't get set, because a flag was only set in set_config_option, but that's not called for lines removed. Repair. (Ref.: commits 62d16c7 and a486e35) Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/202107262302.xsfdfc5sb7sh@alvherre.pgsql
1 parent 336ea6e commit 93a0bf2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/backend/utils/misc/guc-file.l

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,8 @@ ProcessConfigFileInternal(GucContext context, bool applySettings, int elevel)
346346
continue;
347347
if (gconf->context < PGC_SIGHUP)
348348
{
349+
/* The removal can't be effective without a restart */
350+
gconf->status |= GUC_PENDING_RESTART;
349351
ereport(elevel,
350352
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
351353
errmsg("parameter \"%s\" cannot be changed without restarting the server",

0 commit comments

Comments
 (0)