While having a parallel-make-safe genbki.sh is good, it's better not to

petere · petere · commit 95261c44d250 · 2003-08-01T16:12:32.000Z
uselessly invoke it in parallel in the first place.
diff --git a/src/backend/catalog/Makefile b/src/backend/catalog/Makefile
@@ -2,7 +2,7 @@
 #
 # Makefile for backend/catalog
 #
-# $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.46 2003/04/06 22:45:22 petere Exp $
+# $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.47 2003/08/01 16:12:32 petere Exp $
 #
 #-------------------------------------------------------------------------
 
@@ -37,7 +37,10 @@ POSTGRES_BKI_SRCS := $(addprefix $(top_srcdir)/src/include/catalog/,\
 
 pg_includes := $(sort -I$(top_srcdir)/src/include -I$(top_builddir)/src/include)
 
-postgres.bki postgres.description: genbki.sh $(POSTGRES_BKI_SRCS) \
+# see explanation in ../parser/Makefile
+postgres.description: postgres.bki ;
+
+postgres.bki: genbki.sh $(POSTGRES_BKI_SRCS) \
     $(top_srcdir)/src/include/postgres_ext.h $(top_builddir)/src/include/pg_config_manual.h
 	CPP='$(CPP)' AWK='$(AWK)' $(SHELL) $< $(BKIOPTS) -o postgres $(pg_includes) $(POSTGRES_BKI_SRCS) --set-version=$(VERSION)
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`#`
`3`	`3`	`# Makefile for backend/catalog`
`4`	`4`	`#`
`5`		`-# $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.46 2003/04/06 22:45:22 petere Exp $`
	`5`	`+# $Header: /cvsroot/pgsql/src/backend/catalog/Makefile,v 1.47 2003/08/01 16:12:32 petere Exp $`
`6`	`6`	`#`
`7`	`7`	`#-------------------------------------------------------------------------`
`8`	`8`
`@@ -37,7 +37,10 @@ POSTGRES_BKI_SRCS := $(addprefix $(top_srcdir)/src/include/catalog/,\`
`37`	`37`
`38`	`38`	`pg_includes := $(sort -I$(top_srcdir)/src/include -I$(top_builddir)/src/include)`
`39`	`39`
`40`		`-postgres.bki postgres.description: genbki.sh $(POSTGRES_BKI_SRCS) \`
	`40`	`+# see explanation in ../parser/Makefile`
	`41`	`+postgres.description: postgres.bki ;`
	`42`	`+`
	`43`	`+postgres.bki: genbki.sh $(POSTGRES_BKI_SRCS) \`
`41`	`44`	`$(top_srcdir)/src/include/postgres_ext.h $(top_builddir)/src/include/pg_config_manual.h`
`42`	`45`	`CPP='$(CPP)' AWK='$(AWK)' $(SHELL) $< $(BKIOPTS) -o postgres $(pg_includes) $(POSTGRES_BKI_SRCS) --set-version=$(VERSION)`
`43`	`46`