Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 95d14b7

Browse files
committed
Fix a couple typos in BRIN code
Typos introduced by commits c1ec02b, b437571 and dae761a. Author: Alvaro Herrera Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/202401091043.e3nrqiad6gb7@alvherre.pgsql
1 parent e6488fc commit 95d14b7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

doc/src/sgml/indexam.sgml

+1-1
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ aminsert (Relation indexRelation,
370370
initially). After the index insertions complete, the memory will be freed
371371
automatically. If additional cleanup is required (e.g. if the cache contains
372372
buffers and tuple descriptors), the AM may define an optional function
373-
<literal>indexinsertcleanup</literal>, called before the memory is released.
373+
<literal>aminsertcleanup</literal>, called before the memory is released.
374374
</para>
375375

376376
<para>

src/backend/access/brin/brin.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ static bool add_values_to_range(Relation idxRel, BrinDesc *bdesc,
222222
BrinMemTuple *dtup, const Datum *values, const bool *nulls);
223223
static bool check_null_keys(BrinValues *bval, ScanKey *nullkeys, int nnullkeys);
224224
static void brin_fill_empty_ranges(BrinBuildState *state,
225-
BlockNumber prevRange, BlockNumber maxRange);
225+
BlockNumber prevRange, BlockNumber nextRange);
226226

227227
/* parallel index builds */
228228
static void _brin_begin_parallel(BrinBuildState *buildstate, Relation heap, Relation index,
@@ -1151,8 +1151,8 @@ brinbuild(Relation heap, Relation index, IndexInfo *indexInfo)
11511151
*
11521152
* XXX plan_create_index_workers makes the number of workers dependent on
11531153
* maintenance_work_mem, requiring 32MB for each worker. That makes sense
1154-
* for btree, but not for BRIN, which can do away with much less memory.
1155-
* So maybe make that somehow less strict, optionally?
1154+
* for btree, but not for BRIN, which can do with much less memory. So
1155+
* maybe make that somehow less strict, optionally?
11561156
*/
11571157
if (indexInfo->ii_ParallelWorkers > 0)
11581158
_brin_begin_parallel(state, heap, index, indexInfo->ii_Concurrent,
@@ -2621,7 +2621,7 @@ _brin_parallel_merge(BrinBuildState *state)
26212621

26222622
/*
26232623
* Initialize BrinMemTuple we'll use to union summaries from workers (in
2624-
* case they happened to produce parts of the same paga range).
2624+
* case they happened to produce parts of the same page range).
26252625
*/
26262626
memtuple = brin_new_memtuple(state->bs_bdesc);
26272627

@@ -2932,7 +2932,7 @@ _brin_parallel_build_main(dsm_segment *seg, shm_toc *toc)
29322932
* specified block number. The empty tuple is initialized only once, when it's
29332933
* needed for the first time, stored in the memory context bs_context to ensure
29342934
* proper life span, and reused on following calls. All empty tuples are
2935-
* exactly the same except for the bs_blkno field, which is set to the value
2935+
* exactly the same except for the bt_blkno field, which is set to the value
29362936
* in blkno parameter.
29372937
*/
29382938
static void

0 commit comments

Comments
 (0)