Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 997db12

Browse files
committed
Make GIN test using injection points repeatable
As written, the test would fail when run repeatedly because one of the injection points attached was not detached. This would not matter if the test is rewritten to be concurrently safe, but let's be clean and it is a good practice. Oversight in 6a1ea02. Discussion: https://postgr.es/m/ZfP7IDs9TvrKe49x@paquier.xyz
1 parent 705ec05 commit 997db12

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/test/modules/gin/expected/gin_incomplete_splits.out

+6
Original file line numberDiff line numberDiff line change
@@ -179,3 +179,9 @@ select verify(:next_i);
179179
t
180180
(1 row)
181181

182+
SELECT injection_points_detach('gin-finish-incomplete-split');
183+
injection_points_detach
184+
-------------------------
185+
186+
(1 row)
187+

src/test/modules/gin/sql/gin_incomplete_splits.sql

+2
Original file line numberDiff line numberDiff line change
@@ -143,3 +143,5 @@ select insert_n(:next_i, 10) as next_i
143143
\gset
144144
-- Verify that a scan still works
145145
select verify(:next_i);
146+
147+
SELECT injection_points_detach('gin-finish-incomplete-split');

0 commit comments

Comments
 (0)