Defend against 'update oid'. Someday we might want to support

tglsfdc · tglsfdc · commit 99f61dac7e79 · 1999-04-29T03:01:50.000Z
that, but it'd be a New Feature, wouldn't it ... in the meantime,
avoiding a backend crash seems worthwhile.
diff --git a/src/backend/parser/parse_target.c b/src/backend/parser/parse_target.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_target.c,v 1.34 1999/02/03 21:16:59 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_target.c,v 1.35 1999/04/29 03:01:50 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -216,6 +216,8 @@ MakeTargetEntryExpr(ParseState *pstate,
 		rd = pstate->p_target_relation;
 		Assert(rd != NULL);
 		resdomno = attnameAttNum(rd, colname);
+		if (resdomno <= 0)
+			elog(ERROR, "Cannot assign to system attribute '%s'", colname);
 		attrisset = attnameIsSet(rd, colname);
 		attrtype = attnumTypeId(rd, resdomno);
 		if ((arrayRef != NIL) && (lfirst(arrayRef) == NIL))

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_target.c,v 1.34 1999/02/03 21:16:59 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_target.c,v 1.35 1999/04/29 03:01:50 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -216,6 +216,8 @@ MakeTargetEntryExpr(ParseState *pstate,`
`216`	`216`	`rd = pstate->p_target_relation;`
`217`	`217`	`Assert(rd != NULL);`
`218`	`218`	`resdomno = attnameAttNum(rd, colname);`
	`219`	`+ if (resdomno <= 0)`
	`220`	`+ elog(ERROR, "Cannot assign to system attribute '%s'", colname);`
`219`	`221`	`attrisset = attnameIsSet(rd, colname);`
`220`	`222`	`attrtype = attnumTypeId(rd, resdomno);`
`221`	`223`	`if ((arrayRef != NIL) && (lfirst(arrayRef) == NIL))`