Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 9a7fccd

Browse files
committed
Add missing extern keyword for a couple of numutils functions
In passing, also remove a few surplus empty lines from pg_ltoa and pg_ulltoa_n in numutils.c Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y2ou3xuh.fsf@news-spur.riddles.org.uk Backpatch-through: 13, where these changes were introduced
1 parent 2f48ede commit 9a7fccd

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/backend/utils/adt/numutils.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,6 @@ pg_ultoa_n(uint32 value, char *a)
413413
void
414414
pg_ltoa(int32 value, char *a)
415415
{
416-
417416
uint32 uvalue = (uint32) value;
418417
int len;
419418

@@ -437,7 +436,6 @@ pg_ulltoa_n(uint64 value, char *a)
437436
i = 0;
438437
uint32 value2;
439438

440-
441439
/* Degenerate case */
442440
if (value == 0)
443441
{

src/include/utils/builtins.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ extern int32 pg_atoi(const char *s, int size, int c);
4848
extern int16 pg_strtoint16(const char *s);
4949
extern int32 pg_strtoint32(const char *s);
5050
extern void pg_itoa(int16 i, char *a);
51-
int pg_ultoa_n(uint32 l, char *a);
52-
int pg_ulltoa_n(uint64 l, char *a);
51+
extern int pg_ultoa_n(uint32 l, char *a);
52+
extern int pg_ulltoa_n(uint64 l, char *a);
5353
extern void pg_ltoa(int32 l, char *a);
5454
extern void pg_lltoa(int64 ll, char *a);
5555
extern char *pg_ultostr_zeropad(char *str, uint32 value, int32 minwidth);

0 commit comments

Comments
 (0)