Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 9acda73

Browse files
committed
Fix failure of --jobs with reindexdb and vacuumdb on Windows
FD_SETSIZE needs to be declared before winsock2.h, or it is possible to run into buffer overflow issues when using --jobs. This is similar to pgbench's solution done in a23c641. This has been introduced by 71d84ef, and older versions have been using the default value of FD_SETSIZE, defined at 64. Per buildfarm member jacana, but this impacts all Windows animals running the TAP tests. I have reproduced the failure locally to check the patch. Author: Michael Paquier Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/20190826054000.GE7005@paquier.xyz Backpatch-through: 9.5
1 parent fb57f40 commit 9acda73

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/bin/scripts/scripts_parallel.c

+4
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212
*-------------------------------------------------------------------------
1313
*/
1414

15+
#ifdef WIN32
16+
#define FD_SETSIZE 1024 /* must set before winsock2.h is included */
17+
#endif
18+
1519
#include "postgres_fe.h"
1620

1721
#ifdef HAVE_SYS_SELECT_H

0 commit comments

Comments
 (0)