Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Commit 9f00edc

Browse files
committed
injection_points: Disable one permutation in isolation test "basic"
The first permutation done in the test does a wait, a wakeup then a detach. It is proving to be unstable in the CI for FreeBSD (Windows and Linux are stable). The failure shows that the wait is so slow to finish after being woken up that the detach has the time to finish before the wait, messing up with the expected output. There may be a platform-specific issue going on here, but for now disable this permutation to make the CI runs more stable. Discussion: https://postgr.es/m/ZxrnSGdNtQWAxE3_@paquier.xyz
1 parent ffe12d1 commit 9f00edc

File tree

2 files changed

+2
-27
lines changed

2 files changed

+2
-27
lines changed

src/test/modules/injection_points/expected/basic.out

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,5 @@
11
Parsed test spec with 2 sessions
22

3-
starting permutation: wait1 wakeup2 detach2
4-
injection_points_attach
5-
-----------------------
6-
7-
(1 row)
8-
9-
step wait1: SELECT injection_points_run('injection-points-wait'); <waiting ...>
10-
step wakeup2: SELECT injection_points_wakeup('injection-points-wait');
11-
injection_points_wakeup
12-
-----------------------
13-
14-
(1 row)
15-
16-
step wait1: <... completed>
17-
injection_points_run
18-
--------------------
19-
20-
(1 row)
21-
22-
step detach2: SELECT injection_points_detach('injection-points-wait');
23-
injection_points_detach
24-
-----------------------
25-
26-
(1 row)
27-
28-
293
starting permutation: wait1 detach2 wakeup2
304
injection_points_attach
315
-----------------------

src/test/modules/injection_points/specs/basic.spec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ step wakeup2 { SELECT injection_points_wakeup('injection-points-wait'); }
2626
step detach2 { SELECT injection_points_detach('injection-points-wait'); }
2727

2828
# Detach after wait and wakeup.
29-
permutation wait1 wakeup2 detach2
29+
# This permutation is proving to be unstable on FreeBSD, so disable for now.
30+
#permutation wait1 wakeup2 detach2
3031

3132
# Detach before wakeup. s1 waits until wakeup, ignores the detach.
3233
permutation wait1 detach2 wakeup2

0 commit comments

Comments
 (0)